Repository navigation
fix(deps): replace unmaintained YAML dependency graph - #24
Merged
Merged
Conversation
Signed-off-by: Andrey Bruhanov <mail@alamra.net>
Signed-off-by: Andrey Bruhanov <mail@alamra.net>
reynholm
marked this pull request as ready for review
October 17, 2026 15:45
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Remove
serde_yaml/unsafe-libyamlfrom both shipping Rust dependency graphs and remove only the RUSTSEC-2024-0449 exception. Direct consumers use YAML Organization'syaml_serde0.10.7 /libyaml-rs0.3; the Kubernetes path uses kube ~4.0 and OpenAPI 0.28. Preserve existing YAML semantics and Kubernetes context/authentication, the 295-second read timeout, and disabled automatic retries.Regressions exercise persona/skill frontmatter, workflow parsing and round trips, Desktop migration of unknown/tagged/numeric YAML values, Goose configuration, and Kubernetes kubeconfig/exec authentication. See
docs/fork/YAML_COMPATIBILITY.md.Fixes #19.
Conflict resolution
Merge current
main(9b76dbeb45b9f75de79f42fbb5ce2828e24e0479) into the feature branch. The only conflicts were parallel additions toscripts/fork/patches.jsonand its generatedFORK_PATCHES.md. Preserve the registry entries from both sides and regenerate the Markdown. Include main's public-text rules and sanitized maintenance examples unchanged. Runtime sources, manifests, both lockfiles, test runners, and advisory policy are byte-identical to the previously reviewed feature tipdf656115048967e1c539be6be8974f00db7b345c.Validation
Fresh checks of the resolved merge tree on macOS Apple Silicon:
serde_yamlandunsafe-libyaml.Historical validation on
df656115remains applicable to the unchanged runtime sources:just ci desktop-typecheck, six shipping binary builds, complete seven-package tests (3060 passed), real CLI pack inspection and local CLI→relay→PostgreSQL YAML workflow create/read/update. Independent code review found no important regressions.Current cargo-deny: FAIL, with seven advisories (RUSTSEC-2026-0365, 0367–0372) in
negentropy,zip,zvariant,zbus_names, andzvariant_derive. Complete affected package records are identical to current main. These existing issues are outside this YAML migration; no new exceptions were added. The older audit PASS is historical only. Extra Desktop audit previously reported 11 other advisories shared with the pristine base.Merge authorization and limits
The maintainer explicitly requested conflict resolution and merge on 2026-10-17 after receiving the review's audit and manual-acceptance limitations. That direct instruction supersedes the earlier draft-only handoff. Human native Desktop / live Kubernetes testing has not been reported, and no completed-review attestation is made. Ignored external/infrastructure tests remain ignored. The replacement retains translated unsafe ancestry; this change does not claim a memory-safety rewrite. No release or deployment is included.