VideoFrameSequence as a potential alternative to ImageSequence, Optional Cache Location, added repeat methods#62
Open
JingchengYang4 wants to merge 6 commits intorezoo:mainfrom
Open
VideoFrameSequence as a potential alternative to ImageSequence, Optional Cache Location, added repeat methods#62JingchengYang4 wants to merge 6 commits intorezoo:mainfrom
JingchengYang4 wants to merge 6 commits intorezoo:mainfrom
Conversation
JingchengYang4
commented
May 19, 2024
- ImageSequence seems to perform oddly in some cases, its implementation is overcomplicating the actual expected features. It produces issues when the fps does not match and requires users to calculate durations etc. I've tried using it and it creates gaps between videos with missing frames etc.
- VideoFrameSequence is a simpler implementation that solves all the said problems, it's also made to work well with mv.repeat and its new features.
- Allow users to specify the location of disk-cache for compositions. It does seem like the library does not properly dispose disk-caches after processing, so I just made a quick fix allowing users to specify the location of the disk cache so they can dispose that folder when done rendering/
- Added a parameter to change the repeat method. The standard method of replaying the video is now the "loop" method, default parameter when calling mv.repeat. However, users can now also use "bounce" to repeat the video backwards after it has completed. (then forward -> backwards -> forward etc.)
Owner
|
Thank you for your PR! |
|
+1 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.