Consolidate code to set antenna port and disable amps. - #16
Conversation
ZeroChaos-
left a comment
There was a problem hiding this comment.
looks good to me, testing then merging
|
@dperret can you add an example of how to use this to the readme? |
Which part? These functions would only be visible to folks developing challengectl. We could add a separate option to disable all of the amps from a given devices file, but that's not in there at the moment. This pull is just for tidying up the code a bit. |
Just an example of how to set a different tx port. Now that it's not hard coded for our one broken sdr it may be useful to others :-) |
|
I added some notes to the readme for it, and another comment to challengectl.py. It's still hardcoded for one of our SDRs, but it should be more clear now where to update things to set a different port. |
|
Manually tested and gtg |
This consolidates the code to set the antenna port and to disable the amps for bladerf devices, rather than having the code duplicated in multiple other places.