Skip to content

Land the 2026-08-10 critique document #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rfrenchseti merged 9 commits into from
Sep 9, 2026
Merged

Land the 2026-08-10 critique document #10

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
0bd00b6
critiques: add the 2026-08-10 bundle and repository state review
rfrenchseti Aug 11, 2026
8c1d48e
critiques: record the code_review_fixes merge in the 2026-08-10 review
rfrenchseti Aug 11, 2026
e4ea629
critiques: record the float64 time fix merge and data rebuild
rfrenchseti Aug 11, 2026
7b67f1f
critiques: withdraw the background mask finding, record the 287RI fix
rfrenchseti Aug 12, 2026
871bebd
critiques: correct the __pycache__ finding and close out section 3.1
rfrenchseti Aug 12, 2026
c4461f6
critiques: record the satellite target reconciliation fix
rfrenchseti Aug 12, 2026
85338e5
critiques: record the resolved external reference questions
rfrenchseti Aug 13, 2026
ff80f09
critiques: repoint the two predecessor paths at archive/
rfrenchseti Sep 9, 2026
39d9775
critiques: archive the 2026-08-10 review
rfrenchseti Sep 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
0 ...es/pds4-bundle-gen-critique-2026-07-19.md → ...ve/pds4-bundle-gen-critique-2026-07-19.md
View file
Open in desktop
File renamed without changes.
2 changes: 1 addition & 1 deletion ...es/pds4-bundle-gen-critique-2026-07-21.md → ...ve/pds4-bundle-gen-critique-2026-07-21.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
**Software reviewed:** `/seti/research/f-ring/f-ring/pds4_bundle_gen/` — `generate_pds4_files.py` (3,817 lines), `templates/*.lblx`, `templates/examples/*.py`, `templates/*.csv`
**Users guide compared against:** `/seti/research/f-ring/f-ring/users_guide/sections/*.tex` (LaTeX sources; `main.pdf` built 2026-07-19, md5 `e6e7eef933…`, shipped identically in the bundle)
**Ground truth:** the regenerated bundle at `/data/fring-bundles/pds4/` (rebuilt 2026-07-21 18:23).
**Predecessor:** `critiques/pds4-bundle-gen-critique-2026-07-19.md`. Line numbers refer to the current files.
**Predecessor:** `critiques/archive/pds4-bundle-gen-critique-2026-07-19.md`. Line numbers refer to the current files.

---

Expand Down
Loading