Move the rings dictionary to version F (1.15.0.0) - #9
Merged
Conversation
The bundle referenced RINGS 1.14.0.0 (PDS4_RINGS_1O00_1E00). Version F is published and is now used throughout: the two schema URLs in the generator, the local copy under data_dictionaries/, and the LIDVID in collection_xml_schema.csv, taken from the new dictionary label as rings-xml_schema_1.24.0.0_1.15.0::1.0. The upgrade is not a drop-in. Diffing the two schemas, the only substantive change is that Reprojection_Grid_Parameters reorders its members: 1.15 puts mean_radial_resolution and mean_longitudinal_resolution *before* their minimum and maximum siblings, where 1.14 put them after. Our labels emitted the 1.14 order, so data_reproj_img.lblx and data_mosaic.lblx now emit mean first. Checked both directions rather than assuming. Regenerating IOSIC_276RB_COMPLITB3001_SI gives 19 labels, all valid against 1.15 and the other four dictionaries; feeding the same label back in the old order is rejected with "mean_radial_resolution: This element is not expected", so the reorder was required and not cosmetic. The user guide quotes that block verbatim in section 4.2, so its excerpt is reordered to match and the PDF in templates/ is rebuilt. Section 7 already listed the fields mean, minimum, maximum, so it needed no change. The guide builds clean at 45 pages with no overfull boxes. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013h7F5N8axKM4bV5eNpPVvV
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moves the rings dictionary from version E (1.14.0.0) to version F (1.15.0.0).
Not a drop-in
Diffing
PDS4_RINGS_1O00_1E00.xsdagainstPDS4_RINGS_1O00_1F00.xsd, the onlysubstantive change is that
Reprojection_Grid_Parametersreorders its members:Our labels emitted the 1.14 order, so
data_reproj_img.lblxanddata_mosaic.lblxnow emit mean first. Bumping only the schema URL would havefailed
validateon all 21,194 reprojected-image and mosaic labels.Verified both directions
Regenerating
IOSIC_276RB_COMPLITB3001_SIin full — data, browse, mosaics,kernels and support files — gives 19 labels, all valid against RINGS 1.15 and
the other four dictionaries. Feeding the same label back with the old ordering
is rejected:
mean_radial_resolution: This element is not expected. So thereorder was required, not cosmetic.
Also updated
generate_pds4_files.py(.xsdand.sch).data_dictionaries/, 1E00 replaced by 1F00.collection_xml_schema.csv, read from the newdictionary label as
rings-xml_schema_1.24.0.0_1.15.0::1.0. Note RINGS againdeclares the three-component form,
_1.15.0, while its own title saysV1.15.0.0.
reordered and the PDF in
templates/rebuilt: 45 pages, no overfull boxes.Section 7 already listed the fields mean, minimum, maximum and needed nothing.
🤖 Generated with Claude Code
https://claude.ai/code/session_013h7F5N8axKM4bV5eNpPVvV