Allow iPhone to be classed as a 'phone'#41
Open
kgodsmark wants to merge 2 commits intorguerreiro:mainfrom
Open
Allow iPhone to be classed as a 'phone'#41kgodsmark wants to merge 2 commits intorguerreiro:mainfrom
kgodsmark wants to merge 2 commits intorguerreiro:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some iPhone user agent strings are not matching to 'phone' - as raised in #31.
This PR:
adds config to the test case in commit 85d92c9 to avoid the default fallback to 'phone'. The test then fails.
adds a condition after all other attempts to match, to match a user agent string including
iPhoneas'phone'. The test passes.The following is how I can now receive
'phone'foriPhone, whilst still receivingnullfor other unknown strings.