Find NLB IPs the documented way#605
Conversation
DNS lookups are not a reliable way to find all of an NLB's listener IPs. There is no guarantee that the DNS server will give your machine all valid listeners, and there may be more than two. Instead, use an AWS documented technique to find all network interfaces associated with an NLB to get those network interfaces' IPs. Use those IPs for the target group for the public NLB.
✅ Deploy Preview for rh-cloud-experts ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
@daxelrod-rh this likely needs both a rebase, as well as a review. Can you please confirm if this change is still needed and if so, can you update the PR for review? |
|
Hey @daxelrod-rh, The fix here is solid—AWS-documented approach is definitely the way to go for NLB IPs instead of DNS lookups. Closing this one though since it's been sitting in draft for 154 days and no word back when @michaelryanmcneill asked about rebasing and confirming it's still needed. Just want to keep things tidy. If you want to pick this back up sometime, just rebase it, flip it out of draft, and we'll get it merged. Easy enough to resurrect whenever. Cheers! |
|
Sorry about that, I must have missed this email in the flurry of notifications after my absence. I wasn't able to reopen this PR, so I created a new one #926 |
3 participants
DNS lookups are not a reliable way to find all of an NLB's listener IPs. There is no guarantee that the DNS server will give your machine all valid listeners, and there may be more than two.
Instead, use an AWS documented technique to find all network interfaces associated with an NLB to get those network interfaces' IPs. Use those IPs for the target group for the public NLB.