Conversation
✅ Deploy Preview for rh-cloud-experts ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Added information about using Azure Policy to tag ARO resources.
Updated Azure Policy link for tagging ARO resources and add location for az commands in several sections.
Updated the location placeholder from '<AZURE-LOCATION>' to '<Azure-location>' in multiple sections and removed the etcd backup schedule.
added missing --location <Azure-location> to az cli commands
nedoshi
reviewed
Apr 10, 2026
Contributor
There was a problem hiding this comment.
The documents is good and solid for someone to follow. Few minor things
- Azure CLI: Align on one minimum (doc mixes 2.30.0+ and 2.84+ line 211).
- Pod/service CIDR: Reconcile OVN-K warning (100.64/100.88) vs suggesting 100.64.x for on-prem overlap—one clear pattern.
- Secrets: Fix Vault CSI link markdown (line 1715).
- Appendix B: Fix Note - (line 2835)
- Comment on Terraform example section: MI is recommended; snippet uses service_principal—replace or label legacy + link MI example.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Initial draft