Fix: defer window visibility until initialization completes - #168
Merged
Conversation
|
Thank you! @rharish101 I think #45 might be finally fixed. I built ReGreet with these changes and there are no flickers and it even applies GTK theme correctly. Everything seem to work perfectly. regret_test_pr.mp4 |
Owner
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi rharish101, thank you for developing such a nice DM!
ReGreet currently maps its application window before the asynchronous component initialization has completed. This can briefly expose an unstyled window before the background and custom CSS are applied.
The fixing is quite straight forward. Disable Relm4's automatic visibility-on-activate behavior and show the window explicitly after initialization. The intented focus on login button is maintained through this bug fix.
Tested with:
I just replace the
/usr/bin/regreetexecutable and it works well on fresh reboot.Demo
|
Reproduce
Run the following command with the minimal configuration on commit
b9bc613(main) ->afff903(zzh/fix-unstyled-flashing)etc.tar.gz