Add config option to skip selecting user/session - #81
Conversation
945672c to
c55bfbc
Compare
|
Hey, |
|
Unfortunately, this is blocked on me figuring out a way to handle the case when the user doesn't have a password set. Right now, the user is automatically logged into their last session, and there would be no way for them to change their session (unless they change the config to disable this feature). You can check the discussion on the issue page: #57. |
|
Just a question but why would a user not have a password set? |
|
Have you thought about letting this set the user in the config.toml? Something like |
Who knows why? It's part of the spec, so I have to handle it.
I'm not sure what you mean by this. |
|
I mean the PR already kind of does this, let the user set it in config or remember after first login if you want to show the password field immediately or not. You don't need to derive it from some command or something where you need extra privileges |
|
Bump |
|
I would like to see this merged in |
|
Hi! I’ve started using ReGreet and came across this PR. Is this still something you’re planning to merge, or has it stalled? I was considering implementing something similar myself, but noticed this already exists, so I wanted to check before duplicating work. |
|
Is this still blocked or did the PR get abandoned with no hopes of coming back? This would be quite a nice feature. |
4125503 to
354d754
Compare
|
Sorry guys, I finally found time to work on it. I've now fixed the issue that blocked me: if the Can people who are still interested test it out and let me know if it works for them? |
354d754 to
9cae163
Compare
When skip_selection auto-clicks login at startup and the user has no auth configured, greetd returns Success immediately, logging them in without any chance to change user or session. Track whether this is the first login to intercept this case: cancel the session and return to the UI so the user can confirm their selection manually.
9cae163 to
4f0e1c8
Compare
|
Works fine for me. Tested on virtualbox vm, archlinux. Cloned Please push it to the main branch soon :) |
Resolves #57 and resolves #33.