Repository navigation
Complete test-fixture sanitization for Alex Rivera - #70
Merged
Merged
Conversation
|
Important Review skippedBot user detected. To trigger a single review, invoke the ⚙️ Run configurationConfiguration used: Repository: rheos/coderabbit/.coderabbit.yaml Review profile: CHILL Plan: Advanced Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
Co-authored-by: rheos <7797788+rheos@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Finish the sanitize pass in tests
Complete test-fixture sanitization for Sep 28, 2026
Alex Rivera
"Alex" is 4 characters, not 6; the gate reasoning (length >= 4) is unchanged. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The prior repository sanitization pass updated production fixtures but left
Alex Goodwinreferences intests/, including one case where the expected Levenshtein distance changed and could not be handled by a blind rename. This updates the remaining public test surface to the sanitized name and aligns the distance-based assertions with the new fixture text.Remaining fixture cleanup
Alex Goodwinreferences in integration tests withAlex Rivera.Distance assertion recompute
levenshtein('alex', 'alex rivera')expectation from8to7and updated the inline explanation accordingly.Touched coverage
tests/integration/extraction.test.tstests/integration/mcp-tools.test.ts