Skip to content

Complete test-fixture sanitization for Alex Rivera - #70

Merged
rheos merged 3 commits into
mainfrom
copilot/finish-sanitize-pass-in-tests
Sep 29, 2026
Merged

rheos merged 3 commits into
mainfrom
copilot/finish-sanitize-pass-in-tests

Conversation

Copilot AI commented Sep 28, 2026 •

Copy link
Copy Markdown
Contributor

The prior repository sanitization pass updated production fixtures but left Alex Goodwin references in tests/, including one case where the expected Levenshtein distance changed and could not be handled by a blind rename. This updates the remaining public test surface to the sanitized name and aligns the distance-based assertions with the new fixture text.

  • Remaining fixture cleanup

    • Replaced the last Alex Goodwin references in integration tests with Alex Rivera.
    • Updated the MCP entity-search fixture/expectation to match the sanitized test data.
  • Distance assertion recompute

    • Adjusted the extraction/dedup test that documents the prefix-match path rather than the edit-distance gate.
    • Recomputed the levenshtein('alex', 'alex rivera') expectation from 8 to 7 and updated the inline explanation accordingly.
  • Touched coverage

    • tests/integration/extraction.test.ts
    • tests/integration/mcp-tools.test.ts
it('"Alex" vs "Alex Rivera" → 7 (caught by prefix, not distance)', () => {
  expect(levenshtein('alex', 'alex rivera')).toBe(7);
});

Copilot AI linked an issue Sep 28, 2026 that may be closed by this pull request
@coderabbitai

coderabbitai Bot commented Sep 28, 2026 •

Copy link
Copy Markdown

Important

Review skipped

Bot user detected.

To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository: rheos/coderabbit/.coderabbit.yaml

Review profile: CHILL

Plan: Advanced

Run ID: 1e24a010-31d7-4f80-b779-79ff7ababc1a

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Comment @coderabbitai help to get the list of available commands.

Co-authored-by: rheos <7797788+rheos@users.noreply.github.com>
Copilot AI changed the title [WIP] Finish the sanitize pass in tests Complete test-fixture sanitization for Alex Rivera Sep 28, 2026
Copilot AI requested a review from rheos September 28, 2026 03:52
"Alex" is 4 characters, not 6; the gate reasoning (length >= 4) is unchanged.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@rheos
rheos marked this pull request as ready for review September 29, 2026 03:32
@rheos
rheos merged commit b263c86 into main Sep 29, 2026
2 checks passed
@rheos
rheos deleted the copilot/finish-sanitize-pass-in-tests branch September 29, 2026 03:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Finish the sanitize pass in tests/

2 participants