Repository navigation
config: keep a configured local filesystem ('fileysstem' typo) - #40
Open
H1nokam1Kagura wants to merge 1 commit into
Open
H1nokam1Kagura wants to merge 1 commit into
H1nokam1Kagura wants to merge 1 commit into
Conversation
The default-local check looked for the misspelled key 'fileysstem', so it was always true and replaced any configured local filesystem (toml, env var or config_parameter) with ~/.nuthatch/caches. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Author
|
Local test results (the Actions run is waiting for approval, since this PR comes from a fork)
No test passes on |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this fixes
NuthatchConfigreplaced any configured local cache location with~/.nuthatch/caches. The default-local check atsrc/nuthatch/config.py:334tests for the misspelled key'fileysstem':That condition is always true, so
[nuthatch.local] filesystem = …(toml),NUTHATCH_LOCAL_FILESYSTEM(environment variable) and@config_parameter('filesystem', location='local')were all overwritten, anddefault_localwas set toTrue. This PR changes one character,'fileysstem'→'filesystem', and adds a regression test.This also affects sheerwater, which sets
[tool.nuthatch.local] filesystem = "~/.cache/nuthatch".Why the existing tests didn't catch it
tests/test_cache_args.pyalready registers./.cache2as thelocalfilesystem for thetestsmodule. Onmainthat registration is silently discarded. With this fix it is honoured, so the existing suite now uses the local path its author configured.Tests
test_configured_local_filesystem_is_keptsetsNUTHATCH_LOCAL_FILESYSTEMand checks that the configured path survives anddefault_localis false. It uses a module name with no registeredconfig_parameter, so thattest_cache_args.py's registration can't interfere.main(~/.nuthatch/caches) and passes with the fix, both alone and in the full suite.mainand on this branch, on Windows and without cloud credentials. The same 40 tests fail on both. 31 hitOSError: pytest: reading from stdin while output is captured, and 9 areNuthatchReadError(no GCS credentials). They're environmental, not related to this change. CI should cover them.Related
Found alongside a separate issue about
@timeseriesreturning a cache that ends before the requestedend_time; that's #41, opened as an issue because the fix there is a design choice.🤖 Generated with Claude Code