Conversation
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: iNecas The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
iNecas
force-pushed
the
ols-tool-ui-rebase
branch
from
1840dfb to
8bd371c
Compare
|
@iNecas: This pull request references GIE-497 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.22.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
iNecas
force-pushed
the
ols-tool-ui-rebase
branch
from
8bd371c to
d9abb7e
Compare
iNecas
force-pushed
the
ols-tool-ui-rebase
branch
from
d9abb7e to
9735337
Compare
|
there should not be too much change here, there is one idea of @falox of splitting the execute query range and show_timeseries, and but that's mainly about what tools get annotated. |
To support tool.meta attribute.
iNecas
force-pushed
the
ols-tool-ui-rebase
branch
from
9735337 to
53d5d28
Compare
This addresses two problems: - too many visualizations when multiple execute_range_query tools are called during the response - using instance query - for visuzliation time series is usually still more useful to illustrate the data.
iNecas
force-pushed
the
ols-tool-ui-rebase
branch
from
53d5d28 to
3c05ec2
Compare
|
PR needs rebase. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
3 participants
Annotate the tool call to be picked by up OLS with openshift/lightspeed-console#1576