chore(deps): drop the unused gulp dependency + ignore migration-gated majors - #133
Merged
Conversation
… majors gulp was declared in packages/n8n-nodes-multiwa devDependencies — a leftover from the n8n community-node scaffold (which uses `gulp build:icons`) — but this package builds with `tsc && cp -f …svg`, has no gulpfile, and never imports it. Removing the dead dep drops 2,097 lines of transitive tree from the lockfile (and with it gulp 4's aging sub-dependencies). Verified: only gulp's own specifier disappears; the remaining diff is packages flipping to `optional`. Also ignore two more majors that can't be drop-in bumped, so Dependabot stops re-opening PRs that can never merge: - tailwindcss — v4 is a full migration (new engine, CSS-first config, changed class semantics); pairs with the tailwind-merge v3 hold. - @vitest/coverage-v8 — must match the vitest major (pinned ^2), so it can only move as part of a deliberate vitest upgrade. n8n-nodes build + api/worker typecheck green; lockfile still air-gap safe (0 ssh refs).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes out the Dependabot triage.
1. Remove the dead
gulpdependencygulpsat inpackages/n8n-nodes-multiwadevDependencies — a leftover from the n8n community-node scaffold (whose template runsgulp build:icons). This package instead builds withtsc && cp -f …svg, has no gulpfile, and never imports it.Dependabot kept proposing
gulp 4→5(#129) for a dependency nothing uses. Removing it instead:pnpm-lock.yaml(gulp 4 drags a large, aging sub-dependency graph)specifier/versionpair removed is gulp's own^4.0.2; the rest of the diff is packages flipping tooptional: true.2. Two more
ignorerules for majors that can't be drop-in bumpedtailwindcss— v4 is a full migration (new engine, CSS-first config, notailwind.config.js, changed class semantics). Pairs with the existingtailwind-mergev3 hold. (build(deps-dev): bump tailwindcss from 3.4.19 to 4.3.3 #132 closed)@vitest/coverage-v8— must match thevitestmajor (pinned^2), so it can only move as part of a deliberate vitest upgrade, never on its own. (build(deps-dev): bump @vitest/coverage-v8 from 2.1.9 to 4.1.10 #131 closed)Verification
n8n-nodes-multiwabuild ✓ ·api/workertsc --noEmit✓ssh://refs — thepnpm.overridesHTTPS pins hold)dependabot.ymlparses as valid YAMLTriage summary (this pass)
Merged (10): #114 setup-python · #116 production-group (19 deps) · #117 framer-motion 12 · #120 bcrypt 6 · #121 nodemailer 9 · #122 pino 10 · #126 lucide 0.577 · #127 dev-group (9) · #128 globals 17 · #130 @eslint/js
Closed with reasons (8): #115 dev-group (majors) · #118/#119 React 19 (needs Next 15) · #123 tailwind-merge 3 · #124 lucide 1.x · #129 gulp (dead) · #131 coverage-v8 (vitest mismatch) · #132 tailwind v4
Config (#125 + this): dev group restricted to minor/patch; migration-gated majors ignored.
Post-merge
mainverified: all workspace packages build, api/worker/admin typecheck, api 324/324 + worker 34/34 tests green.