chore(deps): align vitest across the workspace + ignore migration-gated majors - #140
Merged
Conversation
…ed majors packages/sdk pinned vitest ^1.2.2 while apps/api and apps/worker were on ^2.0.0. That split is why Dependabot kept proposing a separate sdk-only vitest bump (#134, 1.6.1 -> 4.1.10) that could never merge cleanly. Align sdk to ^2.0.0 so one vitest major governs the whole workspace (and matches the ^2 pin on @vitest/coverage-v8). Drops 249 lines of duplicate vitest-1 tree from the lockfile; sdk tests stay green (17/17). Ignore three more majors that need a coordinated migration, so Dependabot stops re-opening PRs that can never merge as-is: - next Next 15+ requires React 19, which is already ignored for the same reason; the admin crosses both majors together or not at all (#138). - vitest must move in lockstep with @vitest/coverage-v8 and every workspace package, so a major is one deliberate PR, never a per-package one (#134). - n8n-workflow 2.x is a new n8n node-API major; the published n8n-nodes-multiwa package must be reconciled against it and re-published (#137). All packages build; api/worker/admin typecheck; api 324/324, worker 34/34, sdk 17/17 green; lockfile still air-gap safe (0 ssh refs).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes out the second Dependabot triage wave.
1. Align
vitestacross the workspacepackages/sdkpinnedvitest ^1.2.2whileapps/apiandapps/workerwere on^2.0.0. That split is itself a PR generator — it's why Dependabot kept proposing a separate sdk-only bump (#134,1.6.1 → 4.1.10) that could never merge cleanly and would have left the workspace split three ways.Aligning sdk to
^2.0.0means one vitest major governs everything (and matches the^2pin on@vitest/coverage-v8). Drops 249 lines of duplicate vitest-1 tree from the lockfile; sdk tests stay green (17/17).2. Three more
ignorerules for migration-gated majorsnextvitest@vitest/coverage-v8and every workspace package → one deliberate PR, never per-package (#134 closed)n8n-workflown8n-nodes-multiwamust be reconciled against it and re-published (#137 closed)Verification
api/worker/admintypecheck ✓ssh://refs)dependabot.ymlparses; 13 migration-gated majors now ignoredThis wave's triage
Merged (4): #135
@fastify/multipart10 · #136@types/nodemailer8 (aligned all 3 packages) · #139@fastify/static10.1.2 — SECURITY FIX · this PRClosed with reasons (3): #134 vitest (workspace split) · #137 n8n-workflow 2.x · #138 next 14→16