Skip to content

build(deps-dev): bump n8n-workflow from 1.120.7 to 1.120.22 in the dev-dependencies group - #141

Closed
dependabot[bot] wants to merge 1 commit into
mainfrom
dependabot/npm_and_yarn/dev-dependencies-6989e119d3
Closed

build(deps-dev): bump n8n-workflow from 1.120.7 to 1.120.22 in the dev-dependencies group#141
dependabot[bot] wants to merge 1 commit into
mainfrom
dependabot/npm_and_yarn/dev-dependencies-6989e119d3

Conversation

@dependabot

@dependabot dependabot Bot commented on behalf of github Jul 27, 2026

Copy link
Copy Markdown
Contributor

Bumps the dev-dependencies group with 1 update: n8n-workflow.

Updates n8n-workflow from 1.120.7 to 1.120.22

Release notes

Sourced from n8n-workflow's releases.

stable

2.31.7 (2026-07-27)

Bug Fixes

  • core: Avoid loading execution data during credentials security audit (#34912) (0b61a96)
  • core: Sign S3 object paths with strict RFC 3986 encoding (#34873) (75b0d34)

n8n@2.31.7

2.31.7 (2026-07-27)

Bug Fixes

  • core: Avoid loading execution data during credentials security audit (#34912) (0b61a96)
  • core: Sign S3 object paths with strict RFC 3986 encoding (#34873) (75b0d34)

... (truncated)

Commits
Maintainer changes

This version was pushed to npm by GitHub Actions, a new releaser for n8n-workflow since your current version.


Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore <dependency name> major version will close this group update PR and stop Dependabot creating any more for the specific dependency's major version (unless you unignore this specific dependency's major version or upgrade to it yourself)
  • @dependabot ignore <dependency name> minor version will close this group update PR and stop Dependabot creating any more for the specific dependency's minor version (unless you unignore this specific dependency's minor version or upgrade to it yourself)
  • @dependabot ignore <dependency name> will close this group update PR and stop Dependabot creating any more for the specific dependency (unless you unignore this specific dependency or upgrade to it yourself)
  • @dependabot unignore <dependency name> will remove all of the ignore conditions of the specified dependency
  • @dependabot unignore <dependency name> <ignore condition> will remove the ignore condition of the specified dependency and ignore conditions

@dependabot
build(deps-dev): bump n8n-workflow in the dev-dependencies group
5c9b1d7 
Bumps the dev-dependencies group with 1 update: [n8n-workflow](https://github.com/n8n-io/n8n).


Updates `n8n-workflow` from 1.120.7 to 1.120.22
- [Release notes](https://github.com/n8n-io/n8n/releases)
- [Commits](https://github.com/n8n-io/n8n/commits)

---
updated-dependencies:
- dependency-name: n8n-workflow
  dependency-version: 1.120.22
  dependency-type: direct:development
  update-type: version-update:semver-patch
  dependency-group: dev-dependencies
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot Bot added dependencies Pull requests that update a dependency file javascript Pull requests that update javascript code labels Jul 27, 2026
@dependabot
dependabot Bot requested a review from ribato22 as a code owner July 27, 2026 09:04
@dependabot dependabot Bot added dependencies Pull requests that update a dependency file javascript Pull requests that update javascript code labels Jul 27, 2026
@ribato22 ribato22 mentioned this pull request Jul 27, 2026
Merged
ribato22 added a commit that referenced this pull request Jul 27, 2026
@ribato22
fix(deps): skip building the unused isolated-vm native addon + take n…
828f584 
…8n-workflow 1.120.22 (#143)

## The failure

Dependabot #141 (`n8n-workflow 1.120.7 → 1.120.22`) failed three checks
at once — *Lint, Typecheck & Build*, *Public boundary*, *Dependency
audit* — with *Docker Build* and *Tests* skipped. That pattern is always
"the install step died", and the log confirms it:

```
../src/isolate/holder.h:55:22: error: 'void ivm::IsolateTaskRunner::PostTaskImpl(
std::unique_ptr<v8::Task>, const int&)' marked 'final', but is not virtual
gyp ERR! build error / make failed with exit code: 2
   → node_modules/.pnpm/isolated-vm@6.1.2
```

**Not the SSH-lockfile regression** (that guard passed: *"OK: no SSH git
URLs"*). `n8n-workflow 1.120.22` introduces a **new transitive
dependency `isolated-vm@6.1.2`** — n8n's user-code sandbox — whose
native addon doesn't compile against Node 20's V8 headers. `main` (on
1.120.7) has no `isolated-vm` at all, so this is a fresh regression, not
pre-existing.

## The fix

**We never execute that sandbox.** `n8n-workflow` is only a
`devDependency` + `peerDependency` of `packages/n8n-nodes-multiwa`, used
for TypeScript types when building the node; n8n supplies `isolated-vm`
itself at runtime inside the user's own n8n instance.

So instead of pinning n8n-workflow back or ignoring its patch stream
(which carries real fixes), add:

```jsonc
"pnpm": {
  "neverBuiltDependencies": ["isolated-vm"]
}
```

…and take the 1.120.22 bump in the same PR.

## Proven locally, not assumed
With the setting in place, `pnpm --filter n8n-nodes-multiwa add -D
n8n-workflow@1.120.22`:
- **does** pull `isolated-vm@6.1.2` into the lockfile (same dep that
broke CI)
- **completes cleanly with no node-gyp step**
- is **surgical** — the only lockfile change is n8n-workflow's own
specifier/version (`1.120.7 → 1.120.22`); no other dependency moved

## Verification
- All 6 workspace packages build ✓ (incl. `n8n-nodes-multiwa`)
- `api` / `worker` / `admin` typecheck ✓
- **api 324/324** · **worker 34/34** ✓
- Lockfile still **air-gap safe** (0 `ssh://` refs)

Supersedes #141.
@ribato22

ribato22 commented Jul 27, 2026

Copy link
Copy Markdown
Owner

Superseded by #143, which lands the same n8n-workflow 1.120.22 bump plus the fix that makes it installable.

Root cause of this PR's CI failure: 1.120.22 introduces a new transitive dependency isolated-vm@6.1.2 (n8n's user-code sandbox) whose native addon doesn't compile against Node 20's V8 headers (gyp ERR! ... PostTaskImpl marked 'final', but is not virtual), which killed the install step and with it Lint/Build, Public boundary, and Dependency audit. #143 adds pnpm.neverBuiltDependencies: ["isolated-vm"] — we only consume n8n-workflow for TypeScript types, never that sandbox — so the dep resolves without being compiled. All checks green there.

@ribato22 ribato22 closed this Jul 27, 2026
@dependabot @github

dependabot Bot commented on behalf of github Jul 27, 2026

Copy link
Copy Markdown
Contributor Author

This pull request was built based on a group rule. Closing it will not ignore any of these versions in future pull requests.

To ignore these dependencies, configure ignore rules in dependabot.yml

@dependabot
dependabot Bot deleted the dependabot/npm_and_yarn/dev-dependencies-6989e119d3 branch July 27, 2026 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ribato22 ribato22 Awaiting requested review from ribato22 ribato22 is a code owner

Assignees

No one assigned

Labels

dependencies Pull requests that update a dependency file javascript Pull requests that update javascript code

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@ribato22