Harden supply chain and optimize Rust builds - #159
Merged
Conversation
Pin GitHub Actions, scope release permissions, refresh the fuzz lockfile, and apply measured low-risk dependency and CI build optimizations. Assisted-by: AI agent (reviewed by maintainer) Signed-off-by: Richard Ikeda <11233899+richardikeda@users.noreply.github.com>
Record the comparable Ubuntu runner measurement and distinguish the deterministic workflow and artifact improvements from single-run timing variance. Assisted-by: AI agent (reviewed by maintainer) Signed-off-by: Richard Ikeda <11233899+richardikeda@users.noreply.github.com>
Signed-off-by: Richard Ikeda <11233899+richardikeda@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Hardens the dependency and GitHub Actions supply chain and completes the compatible, measured portions of Rust build-performance item 9 in
docs/p0.md.Why
Aikido reported a stale vulnerable fuzz lockfile, mutable third-party Action references, broad release-token permissions, and upstream-retained dependency findings. The P0 audit also identified avoidable dependency features, redundant compilation, slow test scheduling, large debug artifacts, and monomorphization at an MLS callback boundary. This PR addresses those findings before the MLS architecture phase without changing protocol behavior.
Changes
fuzz/Cargo.lock; document time-bounded upstream advisory dispositions and compensating controls.line-tables-onlydevelopment debug information to retain file/line diagnostics with substantially smaller build artifacts.rust-lldand localsccache; reject project-wide adoption because the measured gains did not justify the portability and cache complexity.Security Impact
mls-rsRFC, serialization, standard-library, and tree-index features remain explicit; only its unused parallel feature path is removed.cfg_hash, wire format, authentication, authorization, PoW policy, or validation rule changed.Tests
Executed locally:
cargo fmt --all -- --checkcargo clippy --workspace --locked --all-targets --all-features -- -D warningsRUSTDOCFLAGS=-Dwarnings cargo doc --workspace --locked --no-deps --all-featurescargo bench -p spex-bridge --locked --features benchmarks --no-runcargo audit --file Cargo.lockcargo audit --file fuzz/Cargo.lockcargo deny checkscripts/release_gate_docs.shscripts/release_gate_negative_test.shNextest listed the same 214 default-feature and 215 all-feature tests as Cargo. The default suite measured 69.01 seconds versus 182.80 seconds with Cargo's executor on the same host and built artifacts, a 62.2% reduction. Cargo remains responsible for doctests.
Documentation
Updated:
docs/p0.mddocs/build-performance.mddocs/security-advisory-exceptions.mddocs/security.mddocs/index.mdTESTS.mdCONTRIBUTING.mdCHANGELOG.mdVersioning
VERSION.md: 1.0.31Notes for Reviewers
mls-rsfeatures and the concrete callback boundary inspex-mls.lld/mold, keyring replacement, and cross-linker reproducibility remain explicitly unchecked until they can be measured on compatible platforms; no unsupported default was introduced.Hosted validation
GitHub Actions run
30215940075passed the complete required gate. On Ubuntu stable, Nextest passed 214/214 default-feature tests in 149.539 seconds and 215/215 all-feature tests in 151.325 seconds; Cargo doctests also passed. The workflow publishedrust-test-timings-Linux-stableandrelease-critical-test-timings. This first run followed manifest/profile changes and is evidence of correctness and observability, not a warm-cache performance claim.