Various improvments#1
Open
gonzzor wants to merge 9 commits into
Open
Conversation
If a file spans more than one block and that block isn't found during mount it would be possible for uffs_ftruncate() to end up in an endless loop. Ensure that this doesn't happen by breaking the loop if do_TruncateInternalWithBlockRecover() fails for any reason. The error code is already set by do_TruncateInternalWithBlockRecover().
Doing seek and ftruncate on a directory is wrong, but give the user a better clue of why this happened.
In preparation for the next commits, break out the current loop into a separate function. Fix a typo in the log as well.
rickyzheng
approved these changes
Sep 11, 2020
rickyzheng
approved these changes
Sep 11, 2020
rickyzheng
approved these changes
Sep 11, 2020
rickyzheng
approved these changes
Sep 11, 2020
rickyzheng
approved these changes
Sep 11, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some minor corrections but most notably an improved checking of the tree during mount.