Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the Expo plugin configuration from JavaScript to TypeScript and updates the build pipeline to improve compatibility and development experience.
- Migrates the Expo plugin from JavaScript to TypeScript for better type safety
- Updates the build process to compile TypeScript plugin files and adjusts entry points
- Adds new development dependencies and enhances CI configuration for publishing
Reviewed Changes
Copilot reviewed 6 out of 7 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| plugin/withVosk.js | Removed original JavaScript plugin implementation |
| plugin/tsconfig.json | Added TypeScript configuration for the plugin directory |
| plugin/src/withVosk.ts | Created TypeScript version of the Expo plugin with improved type definitions |
| package.json | Updated version, build script, and added TypeScript-related dependencies |
| app.plugin.js | Updated entry point to reference the compiled TypeScript build output |
| .github/workflows/npm-publish.yml | Enhanced CI workflow with proper permissions and Node.js setup |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update the Expo plugin to improve its configuration and ensure compatibility with the latest dependencies. Adjust the build process and enhance TypeScript support for better development experience.