-
Notifications
You must be signed in to change notification settings - Fork 29
Fix/expo ios #154
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Fix/expo ios #154
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,162 +1,162 @@ | ||
| { | ||
| "name": "react-native-vosk", | ||
| "version": "2.1.2", | ||
| "description": "Speech recognition module for react native using Vosk library", | ||
| "types": "lib/typescript/src/index.d.ts", | ||
| "main": "lib/commonjs/index.js", | ||
| "module": "lib/module/index.js", | ||
| "react-native": "src/index.ts", | ||
| "files": [ | ||
| "src", | ||
| "lib", | ||
| "android", | ||
| "ios", | ||
| "plugin/build", | ||
| "cpp", | ||
| "app.plugin.js", | ||
| "*.podspec", | ||
| "react-native.config.js", | ||
| "!ios/build", | ||
| "!android/build", | ||
| "!android/gradle", | ||
| "!android/gradlew", | ||
| "!android/gradlew.bat", | ||
| "!android/local.properties", | ||
| "!**/__tests__", | ||
| "!**/__fixtures__", | ||
| "!**/__mocks__", | ||
| "!**/.*" | ||
| ], | ||
| "scripts": { | ||
| "example": "yarn workspace react-native-vosk-example", | ||
| "test": "jest", | ||
| "typecheck": "tsc", | ||
| "lint": "eslint \"**/*.{js,ts,tsx}\"", | ||
| "clean": "del-cli android/build example/android/build example/android/app/build example/ios/build lib", | ||
| "prepare": "bob build && tsc --project plugin/tsconfig.json", | ||
| "release": "release-it" | ||
| }, | ||
| "keywords": [ | ||
| "react-native", | ||
| "ios", | ||
| "android", | ||
| "vosk", | ||
| "speech-to-text", | ||
| "speech-recognition", | ||
| "asr", | ||
| "offline" | ||
| ], | ||
| "repository": { | ||
| "type": "git", | ||
| "url": "git+https://github.com/riderodd/react-native-vosk.git" | ||
| }, | ||
| "author": "riderodd <contact@jg-web.site> (https://github.com/riderodd)", | ||
| "license": "MIT", | ||
| "bugs": { | ||
| "url": "https://github.com/riderodd/react-native-vosk/issues" | ||
| }, | ||
| "homepage": "https://github.com/riderodd/react-native-vosk#readme", | ||
| "publishConfig": { | ||
| "registry": "https://registry.npmjs.org/" | ||
| }, | ||
| "devDependencies": { | ||
| "@commitlint/config-conventional": "^19.8.1", | ||
| "@eslint/compat": "^1.3.2", | ||
| "@eslint/eslintrc": "^3.3.1", | ||
| "@eslint/js": "^9.35.0", | ||
| "@evilmartians/lefthook": "^1.12.3", | ||
| "@expo/config-plugins": "^54.0.1", | ||
| "@react-native-community/cli": "20.0.1", | ||
| "@react-native/babel-preset": "0.81.1", | ||
| "@react-native/eslint-config": "^0.81.1", | ||
| "@release-it/conventional-changelog": "^10.0.1", | ||
| "@types/jest": "^29.5.14", | ||
| "@types/react": "^19.1.0", | ||
| "commitlint": "^19.8.1", | ||
| "del-cli": "^6.0.0", | ||
| "eslint": "^9.35.0", | ||
| "eslint-config-prettier": "^10.1.8", | ||
| "eslint-plugin-jest": "^29.0.1", | ||
| "eslint-plugin-prettier": "^5.5.4", | ||
| "expo-module-scripts": "^5.0.7", | ||
| "jest": "^29.7.0", | ||
| "prettier": "^3.6.2", | ||
| "react": "19.1.0", | ||
| "react-native": "0.81.1", | ||
| "react-native-builder-bob": "^0.40.13", | ||
| "release-it": "^19.0.4", | ||
| "turbo": "^2.5.6", | ||
| "typescript": "^5.9.2" | ||
| }, | ||
| "peerDependencies": { | ||
| "react": "*", | ||
| "react-native": "*" | ||
| }, | ||
| "workspaces": [ | ||
| "example" | ||
| ], | ||
| "packageManager": "yarn@3.8.7+sha512.bbe7e310ff7fd20dc63b111110f96fe18192234bb0d4f10441fa6b85d2b644c8923db8fbe6d7886257ace948440ab1f83325ad02af457a1806cdc97f03d2508e", | ||
| "engines": { | ||
| "node": ">= 18.0.0" | ||
| }, | ||
| "jest": { | ||
| "preset": "react-native", | ||
| "modulePathIgnorePatterns": [ | ||
| "<rootDir>/example/node_modules", | ||
| "<rootDir>/lib/" | ||
| ] | ||
| }, | ||
| "commitlint": { | ||
| "extends": [ | ||
| "@commitlint/config-conventional" | ||
| ] | ||
| }, | ||
| "release-it": { | ||
| "git": { | ||
| "commitMessage": "chore: release ${version}", | ||
| "tagName": "v${version}" | ||
| }, | ||
| "npm": { | ||
| "publish": false | ||
| }, | ||
| "github": { | ||
| "release": true | ||
| }, | ||
| "plugins": { | ||
| "@release-it/conventional-changelog": { | ||
| "preset": { | ||
| "name": "angular" | ||
| } | ||
| } | ||
| } | ||
| }, | ||
| "prettier": { | ||
| "quoteProps": "consistent", | ||
| "singleQuote": true, | ||
| "tabWidth": 2, | ||
| "trailingComma": "es5", | ||
| "useTabs": false | ||
| }, | ||
| "react-native-builder-bob": { | ||
| "source": "src", | ||
| "output": "lib", | ||
| "targets": [ | ||
| "module", | ||
| "commonjs", | ||
| "typescript" | ||
| ] | ||
| }, | ||
| "codegenConfig": { | ||
| "name": "VoskSpec", | ||
| "type": "modules", | ||
| "jsSrcsDir": "src", | ||
| "android": { | ||
| "javaPackageName": "com.vosk" | ||
| } | ||
| }, | ||
| "create-react-native-library": { | ||
| "languages": "kotlin-objc", | ||
| "type": "turbo-module", | ||
| "version": "0.54.2" | ||
| } | ||
| } | ||
| { | ||
| "name": "react-native-vosk", | ||
| "version": "2.1.3", | ||
| "description": "Speech recognition module for react native using Vosk library", | ||
| "types": "lib/typescript/src/index.d.ts", | ||
| "main": "lib/commonjs/index.js", | ||
| "module": "lib/module/index.js", | ||
| "react-native": "src/index.ts", | ||
| "files": [ | ||
| "src", | ||
| "lib", | ||
| "android", | ||
| "ios", | ||
| "plugin/build", | ||
| "cpp", | ||
| "app.plugin.js", | ||
| "*.podspec", | ||
| "react-native.config.js", | ||
| "!ios/build", | ||
| "!android/build", | ||
| "!android/gradle", | ||
| "!android/gradlew", | ||
| "!android/gradlew.bat", | ||
| "!android/local.properties", | ||
| "!**/__tests__", | ||
| "!**/__fixtures__", | ||
| "!**/__mocks__", | ||
| "!**/.*" | ||
| ], | ||
| "scripts": { | ||
| "example": "yarn workspace react-native-vosk-example", | ||
| "test": "jest", | ||
| "typecheck": "tsc", | ||
| "lint": "eslint \"**/*.{js,ts,tsx}\"", | ||
| "clean": "del-cli android/build example/android/build example/android/app/build example/ios/build lib", | ||
| "prepare": "bob build && tsc --project plugin/tsconfig.json", | ||
| "release": "release-it" | ||
| }, | ||
| "keywords": [ | ||
| "react-native", | ||
| "ios", | ||
| "android", | ||
| "vosk", | ||
| "speech-to-text", | ||
| "speech-recognition", | ||
| "asr", | ||
| "offline" | ||
| ], | ||
| "repository": { | ||
| "type": "git", | ||
| "url": "git+https://github.com/riderodd/react-native-vosk.git" | ||
| }, | ||
| "author": "riderodd <contact@jg-web.site> (https://github.com/riderodd)", | ||
| "license": "MIT", | ||
| "bugs": { | ||
| "url": "https://github.com/riderodd/react-native-vosk/issues" | ||
| }, | ||
| "homepage": "https://github.com/riderodd/react-native-vosk#readme", | ||
| "publishConfig": { | ||
| "registry": "https://registry.npmjs.org/" | ||
| }, | ||
| "devDependencies": { | ||
| "@commitlint/config-conventional": "^19.8.1", | ||
| "@eslint/compat": "^1.3.2", | ||
| "@eslint/eslintrc": "^3.3.1", | ||
| "@eslint/js": "^9.35.0", | ||
| "@evilmartians/lefthook": "^1.12.3", | ||
| "@expo/config-plugins": "^54.0.1", | ||
| "@react-native-community/cli": "20.0.1", | ||
| "@react-native/babel-preset": "0.81.1", | ||
| "@react-native/eslint-config": "^0.81.1", | ||
| "@release-it/conventional-changelog": "^10.0.1", | ||
| "@types/jest": "^29.5.14", | ||
| "@types/react": "^19.1.0", | ||
| "commitlint": "^19.8.1", | ||
| "del-cli": "^6.0.0", | ||
| "eslint": "^9.35.0", | ||
| "eslint-config-prettier": "^10.1.8", | ||
| "eslint-plugin-jest": "^29.0.1", | ||
| "eslint-plugin-prettier": "^5.5.4", | ||
| "expo-module-scripts": "^5.0.7", | ||
| "jest": "^29.7.0", | ||
| "prettier": "^3.6.2", | ||
| "react": "19.1.0", | ||
| "react-native": "0.81.1", | ||
| "react-native-builder-bob": "^0.40.13", | ||
| "release-it": "^19.0.4", | ||
| "turbo": "^2.5.6", | ||
| "typescript": "^5.9.2" | ||
| }, | ||
| "peerDependencies": { | ||
| "react": "*", | ||
| "react-native": "*" | ||
| }, | ||
| "workspaces": [ | ||
| "example" | ||
| ], | ||
| "packageManager": "yarn@3.8.7+sha512.bbe7e310ff7fd20dc63b111110f96fe18192234bb0d4f10441fa6b85d2b644c8923db8fbe6d7886257ace948440ab1f83325ad02af457a1806cdc97f03d2508e", | ||
| "engines": { | ||
| "node": ">= 18.0.0" | ||
| }, | ||
| "jest": { | ||
| "preset": "react-native", | ||
| "modulePathIgnorePatterns": [ | ||
| "<rootDir>/example/node_modules", | ||
| "<rootDir>/lib/" | ||
| ] | ||
| }, | ||
| "commitlint": { | ||
| "extends": [ | ||
| "@commitlint/config-conventional" | ||
| ] | ||
| }, | ||
| "release-it": { | ||
| "git": { | ||
| "commitMessage": "chore: release ${version}", | ||
| "tagName": "v${version}" | ||
| }, | ||
| "npm": { | ||
| "publish": false | ||
| }, | ||
| "github": { | ||
| "release": true | ||
| }, | ||
| "plugins": { | ||
| "@release-it/conventional-changelog": { | ||
| "preset": { | ||
| "name": "angular" | ||
| } | ||
| } | ||
| } | ||
| }, | ||
| "prettier": { | ||
| "quoteProps": "consistent", | ||
| "singleQuote": true, | ||
| "tabWidth": 2, | ||
| "trailingComma": "es5", | ||
| "useTabs": false | ||
| }, | ||
| "react-native-builder-bob": { | ||
| "source": "src", | ||
| "output": "lib", | ||
| "targets": [ | ||
| "module", | ||
| "commonjs", | ||
| "typescript" | ||
| ] | ||
| }, | ||
| "codegenConfig": { | ||
| "name": "VoskSpec", | ||
| "type": "modules", | ||
| "jsSrcsDir": "src", | ||
| "android": { | ||
| "javaPackageName": "com.vosk" | ||
| } | ||
| }, | ||
| "create-react-native-library": { | ||
| "languages": "kotlin-objc", | ||
| "type": "turbo-module", | ||
| "version": "0.54.2" | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The
path.relativefunction returns a relative path fromiosRoottorelModelPath, but the variable nameabsSourcesuggests it should be an absolute path. This will likely cause thefs.existsSynccheck on line 39 to fail whenrelModelPathis already an absolute path. Consider usingpath.resolve(configMod.modRequest.projectRoot, relModelPath)instead to create a proper absolute path.