Skip to content

Fix expo ios model path - #156

Merged
riderodd merged 3 commits into
mainfrom
fix/expo-ios-model-path
Sep 12, 2025
Merged

Fix expo ios model path#156
riderodd merged 3 commits into
mainfrom
fix/expo-ios-model-path

Conversation

@riderodd

Copy link
Copy Markdown
Owner

No description provided.

Copilot AI review requested due to automatic review settings September 12, 2025 09:18

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes iOS model path handling in the Expo plugin for react-native-vosk. The issue was with incorrect path resolution when adding model resources to Xcode projects in Expo environments.

  • Corrects the iOS root directory reference from projectRoot to platformProjectRoot
  • Fixes model path resolution by properly joining the project root with relative model paths
  • Updates version to 2.1.4 and adds changelog configuration

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
plugin/src/withVosk.ts Fixes iOS model path resolution by using correct project root references and path joining
package.json Version bump to 2.1.4 and adds changelog configuration
CHANGELOG.md Adds changelog entries for version 2.1.4

@riderodd
riderodd merged commit e2877d9 into main Sep 12, 2025
8 checks passed
@riderodd
riderodd deleted the fix/expo-ios-model-path branch September 12, 2025 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants