Fix expo ios model path - #156
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes iOS model path handling in the Expo plugin for react-native-vosk. The issue was with incorrect path resolution when adding model resources to Xcode projects in Expo environments.
- Corrects the iOS root directory reference from
projectRoottoplatformProjectRoot - Fixes model path resolution by properly joining the project root with relative model paths
- Updates version to 2.1.4 and adds changelog configuration
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| plugin/src/withVosk.ts | Fixes iOS model path resolution by using correct project root references and path joining |
| package.json | Version bump to 2.1.4 and adds changelog configuration |
| CHANGELOG.md | Adds changelog entries for version 2.1.4 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.