Fix ios pcm bitrate - #157
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes iOS PCM bitrate compatibility issues by improving the audio buffer handling for the Vosk speech recognition module. The changes address crashes and format errors when starting recognition on iOS devices.
- Enhanced iOS audio buffer format handling to support both int16 and float32 formats
- Added better concurrency controls and error handling to prevent crashes on multiple starts
- Improved audio session configuration and permission handling flow
Reviewed Changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| package.json | Version bump to 2.1.5 to reflect the iOS PCM bitrate fixes |
| ios/Vosk.mm | Complete rewrite of audio handling with improved format support and concurrency controls |
| CHANGELOG.md | Documents the iOS PCM bitrate fix and related improvements in version 2.1.5 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.