refactor: improve memory usage reporting - #18
Merged
Conversation
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
There was a problem hiding this comment.
Pull request overview
This PR refactors table output memory reporting by extracting system-level memory probing into a dedicated SystemMemoryReader, improving compatibility with environments where ps -p is unsupported (e.g., BusyBox).
Changes:
- Added
SystemMemoryReaderto read RSS from/proc/<pid>/status(preferred) with fallback topsand finallymemory_get_usage(true). - Updated
TableOutput(and factory wiring) to useSystemMemoryReaderfor current process usage and free-memory checks. - Added unit tests for
SystemMemoryReaderand updated the changelog.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| tests/Unit/SystemMemoryReaderTest.php | Adds unit coverage for proc/ps/php-fallback memory probing behavior. |
| src/Orchestrator/Output/TableOutputFactory.php | Wires SystemMemoryReader into TableOutput creation. |
| src/Orchestrator/Output/TableOutput.php | Replaces inline memory probing with SystemMemoryReader. |
| src/Orchestrator/Output/SystemMemoryReader.php | Implements centralized system memory probing logic. |
| CHANGELOG.md | Documents the refactor and BusyBox fix. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.