Skip to content

Implemented the rate limiting accordingly#208

Merged
RUKAYAT-CODER merged 1 commit into
rinafcode:mainfrom
KAMALDEEN333:Rate-Limiting
Mar 23, 2026
Merged

Implemented the rate limiting accordingly#208
RUKAYAT-CODER merged 1 commit into
rinafcode:mainfrom
KAMALDEEN333:Rate-Limiting

Conversation

@KAMALDEEN333
Copy link
Copy Markdown
Contributor

Linked Issue

Closes #199


What does this PR do?

Implemented the rate limiting
Overview
Implemented proper rate limiting on all critical API endpoints to protect against DDoS attacks and brute force attempts.

Background
The rate-limiting module exists but is not properly integrated with controllers. Without rate limiting, the API is vulnerable to abuse, resource exhaustion, and service degradation.

Specifications
Modules to Update:
RateLimitingModule
Add guards to controllers
Tasks:
Configured ThrottlerModule with appropriate limits
Applied throttler guards to auth endpoints (login, register)
Applied throttler guards to payment endpoints
Added custom rate limit headers to responses
Implemented Redis-backed distributed rate limiting
Created rate limit exceeded exception handler
Impacted Files:
src/rate-limiting/services/rate-limiting.module.ts (modify)
src/auth/auth.controller.ts (add guard)
src/payments/payments.controller.ts (add guard)
src/common/guards/throttle.guard.ts (enhance)
src/main.ts (configure throttler)
Labels: backend, security, scalability, priority-high
Acceptance Criteria
Rate limiting active on sensitive endpoints
Brute force attacks prevented on login
Distributed rate limiting works across instances
Proper error responses for rate limit exceeded
Configurable limits via environment variables


Type of change

  • ✨ New feature (non-breaking change that adds functionality)
  • 🐛 Bug fix (non-breaking change that fixes an issue)
  • 💥 Breaking change (fix or feature that changes existing API behaviour)
  • ♻️ Refactor (no functional change, no new feature)
  • 🧪 Tests only (no production code changes)
  • 📝 Documentation only
  • 🔧 Chore (build, dependencies, CI config)

Pre-merge checklist (required)

Do not remove items. Unchecked items without an explanation will block merge.

Branch & metadata

  • Branch name follows feature/issue-<N>-<slug> / fix/issue-<N>-<slug> convention
  • Branch is up to date with the target branch (develop or main)
  • All commits and the PR title follow the Conventional Commits format with issue reference

Code quality & tests

  • npm run lint:ci — zero ESLint warnings
  • npm run format:check — Prettier reports no changes needed
  • npm run typecheck — zero TypeScript errors
  • npm run test:ci — all tests pass, coverage ≥ 70%
  • New service methods have corresponding .spec.ts unit tests
  • New API endpoints are covered by at least one e2e test
  • No existing tests were deleted (if any were, justification is provided in the PR description)

Error handling & NestJS best practices

  • All new/updated DTOs use class-validator / class-transformer decorators and are wired through NestJS pipes (e.g. global ValidationPipe or explicit)
  • All controller entry points validate external input at the boundary (no unvalidated raw any/unknown reaching the domain)
  • Controllers/services throw appropriate NestJS HTTP exceptions (e.g. BadRequestException, UnauthorizedException, ForbiddenException, NotFoundException) instead of generic Error
  • Any new error shapes are handled by existing exception filters or the filters have been updated accordingly
  • Logging goes through the shared logging abstraction (e.g. Nest Logger or central logger service) with meaningful, structured messages
  • Authentication/authorization guards (e.g. AuthGuard, role/permissions guards, custom guards) are applied to all new/modified endpoints where appropriate
  • If an endpoint is intentionally public, this is explicitly mentioned in the PR description with rationale

API documentation / Swagger

  • Swagger / OpenAPI decorators are added or updated for all new/changed controller endpoints (including DTOs, responses, and error schemas)
  • I have started the app locally and confirmed the /api (or Swagger UI) reflects new/changed endpoints correctly
  • If there are no API surface changes, this is explicitly stated in the PR description

Breaking changes

  • This PR does not introduce a breaking API change
  • OR: this PR introduces a breaking change and it is documented below, with migration notes

Breaking change description (if applicable)


Test evidence (required)

Commands run locally

# Example (edit as needed)
npm run lint:ci
npm run format:check
npm run typecheck
npm run test:ci

Manual / API verification

# Example: describe manual tests, curl commands, or Postman collections used

Screenshots / recordings (if applicable)

@drips-wave
Copy link
Copy Markdown

drips-wave Bot commented Mar 23, 2026

@KAMALDEEN333 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits.

You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀

Learn more about application limits

@RUKAYAT-CODER RUKAYAT-CODER merged commit 0366d51 into rinafcode:main Mar 23, 2026
4 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Implement API Rate Limiting

2 participants