Implement pagination limits and validation tests for DTOs#321
Merged
RUKAYAT-CODER merged 1 commit intoApr 24, 2026
Merged
Conversation
|
@Ahmedscreativeverse Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #295
Changes made
Updated pagination.dto.ts
Switched page-size defaults to APP_CONSTANTS.DEFAULT_PAGE_SIZE
Switched max page-size validation to APP_CONSTANTS.MAX_PAGE_SIZE
Added explicit validation message for max page size
Updated pagination.util.ts
Replaced hard-coded pagination defaults with APP_CONSTANTS.DEFAULT_PAGE_SIZE
Updated app.constants.ts
Clarified MAX_PAGE_SIZE as the maximum page size for pagination
Added documentation
Added a README note: pagination is limited to a maximum page size of 100 items per request
Added regression coverage
Created pagination.dto.spec.ts to verify DTO validation for maximum page size