fix: resolve issues #260, #261, #274, #276#322
Merged
RUKAYAT-CODER merged 2 commits intoApr 26, 2026
Conversation
…fcode#276 - rinafcode#260: Verified CreateAssessmentDto and UpdateAssessmentDto already have full validation decorators (IsString, IsNotEmpty, IsOptional, IsEnum, IsUUID, IsNumber, Min, Max). No changes required. - rinafcode#261: Add custom exception classes in src/common/exceptions/app.exceptions.ts (ResourceNotFoundException, ForbiddenOperationException, ResourceConflictException, BusinessValidationException, ServiceUnavailableException) for consistent error handling across services. - rinafcode#274: Add DB connection pool Prometheus metrics (db_pool_connections_acquired_total, db_pool_connections_released_total, db_pool_size) to MetricsCollectionService. Wire pool event hooks in app.module.ts and log pool config at startup. - rinafcode#276: Document caching strategy (cache-aside pattern, TTL policy table, key versioning, event-driven invalidation) in caching.constants.ts. Closes rinafcode#260 Closes rinafcode#261 Closes rinafcode#274 Closes rinafcode#276
|
@TomikeDS Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
Contributor
|
Kindly resolve conflict |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Linked Issue
Closes #260
Closes #261
Closes #274
Closes #276
What does this PR do?
Empty CreateAssessmentDto Validation #260: Verified CreateAssessmentDto and UpdateAssessmentDto already have full validation decorators (IsString, IsNotEmpty, IsOptional, IsEnum, IsUUID, IsNumber, Min, Max). No changes required.
Error Handling Consistency #261: Add custom exception classes in src/common/exceptions/app.exceptions.ts (ResourceNotFoundException, ForbiddenOperationException, ResourceConflictException, BusinessValidationException, ServiceUnavailableException) for consistent error handling across services.
Database Connection Pool Configuration #274: Add DB connection pool Prometheus metrics (db_pool_connections_acquired_total, db_pool_connections_released_total, db_pool_size) to MetricsCollectionService. Wire pool event hooks in app.module.ts and log pool config at startup.
Caching Strategy Documentation #276: Document caching strategy (cache-aside pattern, TTL policy table, key versioning, event-driven invalidation) in caching.constants.ts.
Type of change
Pre-merge checklist (required)
Branch & metadata
feature/issue-<N>-<slug>/fix/issue-<N>-<slug>conventiondevelopormain)Code quality & tests
npm run lint:ci— zero ESLint warningsnpm run format:check— Prettier reports no changes needednpm run typecheck— zero TypeScript errorsnpm run test:ci— all tests pass, coverage ≥ 70%.spec.tsunit testsError handling & NestJS best practices
class-validator/class-transformerdecorators and are wired through NestJS pipes (e.g. globalValidationPipeor explicit)any/unknownreaching the domain)BadRequestException,UnauthorizedException,ForbiddenException,NotFoundException) instead of genericErrorLoggeror central logger service) with meaningful, structured messagesAuthGuard, role/permissions guards, custom guards) are applied to all new/modified endpoints where appropriateAPI documentation / Swagger
/api(or Swagger UI) reflects new/changed endpoints correctlyBreaking changes
Breaking change description (if applicable)
Test evidence (required)
Commands run locally
Manual / API verification
Screenshots / recordings (if applicable)