fix: resolve auto-save race conditions and add conflict detection#235
Merged
RUKAYAT-CODER merged 1 commit intoApr 27, 2026
Merged
Conversation
|
@collinsezedike Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
AutoSaveManager.tsxonSaveSuccess/onSaveErrorin theuseEffectdep array with callback refs — inline functions from the parent were causing the manager to be torn down and rebuilt on every render, creating a race between the outgoing destroy and the incoming enableisSavingRefguard to the debounced save effect so concurrent saves (interval + debounce firing together) can't overlapauto-save-manager.tsonline/offlinehandlers and stored them in instance fields sodestroy()can properlyremoveEventListener— previously they leaked on every unmountsaveNow: before writing, compares the stored draft'supdatedAtagainstlastKnownUpdatedAt(set on load and after each successful save); aborts with an error status if the draft was modified externally (e.g. another tab)destroy()now also clearslastKnownUpdatedAtTest plan
onSaveSuccess/onSaveErrorcallbacks from a parent — manager should not rebuild on every renderonline/offlinelisteners should remain attachedCloses #195