feat(a11y): add focus trap to Modal and manage focus on route changes (#229)#236
Merged
RUKAYAT-CODER merged 1 commit intoApr 27, 2026
Conversation
Closes rinafcode#229 - Add src/components/ui/Modal.tsx: accessible dialog with focus trap, Escape-to-close, aria-labelledby, body scroll lock, and SR announcement - Add useFocusOnRouteChange hook to useAccessibility.tsx: moves focus to <main> landmark on every pathname change - Add RouteChangeAnnouncer component (renders nothing, side-effect only) - Wire RouteChangeAnnouncer into RootProviders inside AccessibilityProvider - Export Modal from src/components/index.ts barrel
|
@solomonokeke012-bot Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #229
Implements proper focus management per the accessibility issue spec.
Changes
src/components/ui/Modal.tsx(new) — Reusable accessible modal with:useFocusTraphook (focus returns to trigger on close)role="dialog",aria-modal,aria-labelledbywith stableuseId()src/hooks/useAccessibility.tsx— AddeduseFocusOnRouteChange(pathname)hook that moves focus to the<main>landmark on every route changesrc/components/accessibility/RouteChangeAnnouncer.tsx(new) — Thin client component that readsusePathname()and callsuseFocusOnRouteChange; renders nothingsrc/providers/RootProviders.tsx— Mounts<RouteChangeAnnouncer />inside<AccessibilityProvider>for app-wide route focus managementsrc/components/index.ts— ExportsModalfrom the component barrelTesting
<main>content areaAcceptance Criteria