Skip to content

chore: improve screen reader support for input fields#546

Merged
RUKAYAT-CODER merged 1 commit into
rinafcode:mainfrom
MerlinTheWhiz:chore/input-screen-reader-support
May 28, 2026
Merged

chore: improve screen reader support for input fields#546
RUKAYAT-CODER merged 1 commit into
rinafcode:mainfrom
MerlinTheWhiz:chore/input-screen-reader-support

Conversation

@MerlinTheWhiz
Copy link
Copy Markdown
Contributor

Closes #523

Changes made:

  • Added explicit label/id, aria-describedby, aria-invalid, aria-required, helper text, and alert-linked errors in src/components/forms/FormInput.tsx:35.
  • Added the same accessible wiring for auth inputs, plus labelled/stateful password visibility controls in src/app/components/auth/FormInput.tsx:40.
  • Added regression tests covering labels, helper text, errors, textarea/select support, and password toggle semantics in src/components/forms/tests/FormInput.test.tsx:23 and src/app/components/auth/tests/FormInput.test.tsx:5.
  • Documented usage guidance in src/app/components/accessibility/README.md:289.

Validation:

  • Passed: pnpm exec vitest run src/components/forms/tests/FormInput.test.tsx src/app/components/auth/tests/FormInput.test.tsx
  • Passed: Prettier check on touched files
  • Blocked: pnpm run type-check fails on pre-existing syntax errors in src/components/assessment/AdaptiveTesting.tsx:43, src/components/assessment/QuestionTypes.tsx:97, and src/lib/api.ts:216.

@drips-wave
Copy link
Copy Markdown

drips-wave Bot commented May 27, 2026

@MerlinTheWhiz Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits.

You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀

Learn more about application limits

@RUKAYAT-CODER RUKAYAT-CODER merged commit b5cf0ba into rinafcode:main May 28, 2026
3 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

chore Input Fields : Screen Reader Support (Issue 125)

2 participants