Skip to content

Refactor/dark light toggle error boundary#548

Merged
RUKAYAT-CODER merged 3 commits into
rinafcode:mainfrom
MerlinTheWhiz:refactor/dark-light-toggle-error-boundary
May 28, 2026
Merged

Refactor/dark light toggle error boundary#548
RUKAYAT-CODER merged 3 commits into
rinafcode:mainfrom
MerlinTheWhiz:refactor/dark-light-toggle-error-boundary

Conversation

@MerlinTheWhiz
Copy link
Copy Markdown
Contributor

Closes #537

Changes made:

  • Added component-level ErrorBoundary protection around ThemeToggle in src/components/ui/theme-toggle.tsx:70.
  • Added an accessible disabled fallback button for toggle failures in src/components/ui/theme-toggle.tsx:9.
  • Preserved existing toggle behavior and added type="button" plus decorative icon aria-hidden attributes.
  • Added focused tests in src/components/ui/tests/theme-toggle.test.tsx:27 and src/components/ui/tests/theme-toggle.test.tsx:43.

Validation:

  • Passed: pnpm vitest run src/components/ui/tests/theme-toggle.test.tsx

@drips-wave
Copy link
Copy Markdown

drips-wave Bot commented May 27, 2026

@MerlinTheWhiz Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits.

You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀

Learn more about application limits

@RUKAYAT-CODER RUKAYAT-CODER merged commit 7589576 into rinafcode:main May 28, 2026
3 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

refactor Dark/Light Toggle : Error Boundary Implementation

2 participants