#528 refactor Wallet Connection : Bug Fix#552
Merged
RUKAYAT-CODER merged 1 commit intoMay 28, 2026
Conversation
|
@A5cend-dev Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Refactored and fixed wallet connection handling across Starknet and MetaMask integrations to improve reliability, provider isolation, and transaction validation behavior.
The update improves wallet validation by allowing either a Starknet or MetaMask extension to satisfy connection requirements, preventing unrelated wallet providers from being blocked when Starknet is unavailable. The wallet connection hook was updated to perform dynamic validation checks during connection attempts instead of relying on stale initialization state.
MetaMask account and chain change listeners were isolated to only affect MetaMask sessions, preventing EVM events from unintentionally disconnecting or overriding Starknet connection state. Wallet connection error handling was also improved by enabling the dismiss action for all active wallet errors instead of limiting it to installation-related messages.
Transaction validation logic in
TransactionManager.tsxwas refactored to support provider-aware address validation for both Starknet and EVM address formats. Decimal and amount serialization was also improved using safe integer math (BigIntandMath.round) to prevent floating-point precision and exponent formatting issues in hexadecimal outputs.Additional unit and component test coverage was added for wallet connection behavior, event isolation, rendering validation, and error dismissal handling. Documentation artifacts including
walkthrough.mdwere completed, and all related implementation tasks were marked as finished intask.md.Related Issue
Closes #528
Type of Change
Bug fix and refactor focused on wallet connection reliability, provider compatibility, transaction validation, and testing improvements.
Notes
The implementation includes both hook-level and component-level test coverage for critical wallet interaction flows. The refactor preserves existing functionality while improving connection stability and reducing provider-specific side effects.