Skip to content

feat(forms): enhance form validation and accessibility (#514) #559

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
RUKAYAT-CODER merged 1 commit into from
May 29, 2026
Merged

feat(forms): enhance form validation and accessibility (#514) #559

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions src/app/(auth)/login/page.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,7 +93,9 @@ export default function LoginPage() {
<input
type="email"
placeholder="john.doe@example.com"
className="w-full px-4 py-3 border border-gray-300 rounded-lg focus:ring-2 focus:ring-cyan-500 outline-none transition-all"
className={`w-full px-4 py-3 border ${errors.email ? 'border-red-500' : 'border-gray-300'} rounded-lg focus:ring-2 focus:ring-cyan-500 outline-none transition-all`}
aria-invalid={!!errors.email}
aria-describedby="email-error"
{...register('email')}
/>
<FieldError error={errors.email?.message} id="email-error" />
Expand All @@ -105,7 +107,9 @@ export default function LoginPage() {
<input
type={showPassword ? 'text' : 'password'}
placeholder="••••••••"
className="w-full px-4 py-3 border border-gray-300 rounded-lg focus:ring-2 focus:ring-cyan-500 outline-none transition-all pr-12"
className={`w-full px-4 py-3 border ${errors.password ? 'border-red-500' : 'border-gray-300'} rounded-lg focus:ring-2 focus:ring-cyan-500 outline-none transition-all pr-12`}
aria-invalid={!!errors.password}
aria-describedby="password-error"
{...register('password')}
/>
<button
Expand Down
35 changes: 32 additions & 3 deletions src/app/(auth)/signup/page.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@ import { apiClient } from '@/lib/api';

export default function SignupPage() {
const [showPassword, setShowPassword] = useState(false);
const [showConfirmPassword, setShowConfirmPassword] = useState(false);
const [successMessage, setSuccessMessage] = useState('');
const router = useRouter();

Expand Down Expand Up @@ -95,7 +96,9 @@ export default function SignupPage() {
<input
type="text"
placeholder="John Doe"
className="w-full px-4 py-3 border border-gray-300 rounded-lg focus:ring-2 focus:ring-cyan-500 focus:border-transparent outline-none transition-all"
className={`w-full px-4 py-3 border ${errors.name ? 'border-red-500' : 'border-gray-300'} rounded-lg focus:ring-2 focus:ring-cyan-500 focus:border-transparent outline-none transition-all`}
aria-invalid={!!errors.name}
aria-describedby="name-error"
{...register('name')}
/>
<FieldError error={errors.name?.message} id="name-error" />
Expand All @@ -106,7 +109,9 @@ export default function SignupPage() {
<input
type="email"
placeholder="john.doe@example.com"
className="w-full px-4 py-3 border border-gray-300 rounded-lg focus:ring-2 focus:ring-cyan-500 focus:border-transparent outline-none transition-all"
className={`w-full px-4 py-3 border ${errors.email ? 'border-red-500' : 'border-gray-300'} rounded-lg focus:ring-2 focus:ring-cyan-500 focus:border-transparent outline-none transition-all`}
aria-invalid={!!errors.email}
aria-describedby="email-error"
{...register('email')}
/>
<FieldError error={errors.email?.message} id="email-error" />
Expand All @@ -118,7 +123,9 @@ export default function SignupPage() {
<input
type={showPassword ? 'text' : 'password'}
placeholder="••••••••"
className="w-full px-4 py-3 border border-gray-300 rounded-lg focus:ring-2 focus:ring-cyan-500 focus:border-transparent outline-none transition-all pr-12"
className={`w-full px-4 py-3 border ${errors.password ? 'border-red-500' : 'border-gray-300'} rounded-lg focus:ring-2 focus:ring-cyan-500 focus:border-transparent outline-none transition-all pr-12`}
aria-invalid={!!errors.password}
aria-describedby="password-error"
{...register('password')}
/>
<button
Expand All @@ -132,6 +139,28 @@ export default function SignupPage() {
<FieldError error={errors.password?.message} id="password-error" />
</div>

<div>
<label className="block text-sm font-medium text-gray-700 mb-2">Confirm Password</label>
<div className="relative">
<input
type={showConfirmPassword ? 'text' : 'password'}
placeholder="••••••••"
className={`w-full px-4 py-3 border ${errors.confirmPassword ? 'border-red-500' : 'border-gray-300'} rounded-lg focus:ring-2 focus:ring-cyan-500 focus:border-transparent outline-none transition-all pr-12`}
aria-invalid={!!errors.confirmPassword}
aria-describedby="confirmPassword-error"
{...register('confirmPassword')}
/>
<button
type="button"
onClick={() => setShowConfirmPassword(!showConfirmPassword)}
className="absolute right-3 top-1/2 -translate-y-1/2 text-gray-500 hover:text-gray-700"
>
{showConfirmPassword ? <EyeOff size={20} /> : <Eye size={20} />}
</button>
</div>
<FieldError error={errors.confirmPassword?.message} id="confirmPassword-error" />
</div>

<FormError error={signupMutation.error?.message} id="signup-api-error" />

{successMessage && (
Expand Down
Loading