feat: implement Accordion component with Registration System#563
Merged
RUKAYAT-CODER merged 1 commit intoMay 29, 2026
Merged
Conversation
- Add Accordion, AccordionItem, AccordionTrigger, AccordionContent - Registration system: each AccordionItem registers/unregisters with the root via a Map registry, enabling cross-item coordination - Support uncontrolled (defaultOpenIds) and controlled (openIds + onOpenChange) modes - Exclusive mode (exclusive prop) closes other items on open - Disabled items block toggling - Variants: default, bordered, ghost - Sizes: sm, md, lg - Full ARIA support: aria-expanded, aria-controls, role=region, aria-labelledby, keyboard activation - 37 unit/integration tests covering all behaviours - Register exports in src/components/index.ts barrel
|
@pugsley76 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #471
Summary
Implements a fully-featured Accordion component with a context-based
Registration System, where each AccordionItem registers/unregisters
itself with the root on mount/unmount.
Changes
Accordion,AccordionItem,AccordionTrigger,AccordionContentMapregistry in the root — enablescross-item coordination (exclusive mode, programmatic control, safe
dynamic unmounting)
defaultOpenIds) and controlled mode (openIds+onOpenChange)exclusiveprop) — only one item open at a timedefault,bordered,ghostsm,md,lgaria-expanded,aria-controls,role="region",aria-labelledby, keyboard activation (Enter / Space)src/components/index.tsbarrel exportTesting
All 37 tests pass. No regressions in existing test suite.
Acceptance Criteria