refactor: Wallet Connection Bug Fix (#503, Issue #105)#574
Merged
Conversation
- Add Starknet event listeners (accountsChanged, networkChanged) to useWeb3Wallet hook - Ensure both MetaMask and Starknet wallet providers have proper event handling - Gracefully handle Starknet wallets that may not support .on()/.off() methods - Add unit test for Starknet accountsChanged event disconnection behavior - All 9 wallet tests passing with no regressions
|
@Muyideen-js Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #503
Overview
This PR addresses issue #503 (referencing #105) by implementing comprehensive bug fixes and proper event handling for the Web3 Wallet Connection flow.
Changes Made
accountsChangedandnetworkChanged) to the Starknet provider inuseWeb3Wallet.tsto mirror the MetaMask implementation..on(),.off(), or.removeListener()methods.should update Starknet connection state when Starknet accountsChanged event is firedinuseWeb3Wallet.test.tsverifying the disconnect flow.Verification
useWeb3Wallet.tsandWalletConnector.tsx.