This repository was archived by the owner on Apr 2, 2021. It is now read-only.
Conversation
Codecov Report
@@ Coverage Diff @@
## master #45 +/- ##
===========================================
+ Coverage 46.47% 59.26% +12.79%
===========================================
Files 12 17 +5
Lines 284 356 +72
===========================================
+ Hits 132 211 +79
+ Misses 152 145 -7 |
Owner
Author
|
@gearsof44 tu peux add tox au requierements |
…without psycopg2, Update README
ripoul
commented
Oct 24, 2019
Owner
Author
|
@gearsof44 You need GEORIDE_EMAIL and GEORIDE_PASSWORD as env vars for the test to pass ? I can set them in the CI as secret. But External PR will not work... |
Owner
Author
|
@all-contributors please add @gearsof44 for code, test |
Contributor
|
I've put up a pull request to add @gearsof44! 🎉 |
Owner
Author
|
@all-contributors please add @gearsof44 for code, test |
Contributor
|
I've put up a pull request to add @gearsof44! 🎉 |
…uirements file sort, export specific test settings to a test_settings file
ripoul
commented
Oct 24, 2019
Owner
Author
|
@gearsof44 why 2 requierement file ? |
Owner
Author
|
@gearsof44 do not force 80% codecov : we have a bot who provide us a coverage report on each PR. For me it is enougth to manage those problems. |
…tor model user & profile to app accounts, add app services containing all georide services, add georide driver + unauthenticated georide driver, begin tests for unauthenticated georide driver
ripoul
commented
Nov 21, 2019
Comment on lines
1
to
3
| runtime: python37 | ||
| entrypoint: gunicorn -b :$PORT georidePosition.wsgi | ||
| entrypoint: gunicorn -b :$PORT apss.georide_position.wsgi | ||
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
first refactor