Skip to content

Fix the UI bugs for the address checking and Set Signer List #14

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dicksonchow wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix the UI bugs for the address checking and Set Signer List #14

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
92562cd
Skip the isFederation check if the destination address is empty
Dec 18, 2018
03810df
Fix the signer.weight bug
Dec 18, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions js/mywallet.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1314,6 +1314,9 @@ walletApp.controller('walletCtrl', ['$scope', '$http', '$uibModal', '$localStora

$scope.isFederation = function (address) {
// checking for email type address (e.g.xyz@domain.com)
if (typeof address === 'undefined') {
return true;
}
return address.search(/@([\w-]+\.)+[\w-]{2,}$/) > 0;
}

Expand Down
2 changes: 1 addition & 1 deletion templetes/modal-set-signer-list.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ <h3 class="modal-title">Set/Change SignerList</h3>
<span style="color:red" ng-show="setSignerListForm.signerAddress{{$index}}.$error.rippleValidAddress">Invalid Address!</span>
</td>
<td style="text-align: center">
<input type="text" min=1 ng-model="options.signers[$index].weight" size="5" name="signerWeight{{$index}}" uint32 required>
<input type="number" min=1 ng-model="options.signers[$index].weight" size="5" name="signerWeight{{$index}}" uint32 required>
<span style="color:red" ng-show="setSignerListForm.signerWeight{{$index}}.$dirty && setSignerListForm.signerWeight{{$index}}.$invalid">Invalid Value!</span>
</td>
<td><button class="btn btn-link" ng-click="options.signers.splice($index,1)"><span class="glyphicon glyphicon-trash"></span></button></td>
Expand Down