Repository navigation
fix(build): fetch the contract jars from a pinned release, not latest - #27
Open
abhinavlenka wants to merge 1 commit into
Open
abhinavlenka wants to merge 1 commit into
abhinavlenka wants to merge 1 commit into
Conversation
A clean checkout could not build: downloadDeps asked the latest BossConsole-Releases release for boss-ipc-<ipc.version>.jar, and from v9.5.20 on no release ships boss-ipc-1.0.0.jar. The version was pinned while the release it came from floated. - gradle.properties gains upstream.release.tag=v9.5.19, the newest release that ships boss-ipc-1.0.0 and the three 1.0.0 contract jars; bump it with ipc.version. - downloadDeps defaults to that tag. -Pupstream.source still overrides it. - A jar missing from the release now fails with a message naming the jar, the release and the two properties to change, instead of a bare FileNotFoundException. - Each jar is written to a .part file and moved into place when complete, so a download cut off part-way no longer leaves a truncated jar that the "already present" check accepts on every later run. - release.yml passes /releases/latest/download explicitly when no tag is given, so a release run behaves exactly as before, including one that overrides ipc_version. Fixes risa-labs-inc#26
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #26.
Problem
A clean checkout can't build.
downloadDepsasks the latest BossConsole-Releases release forboss-ipc-<ipc.version>.jar, butipc.versionis pinned to1.0.0, and from v9.5.20 onwards no release ships that jar (v9.5.20 ships 1.1.0, v9.5.21 and v9.5.22 ship 1.2.0). Reproduced onmain:Change
upstream.release.tag=v9.5.19ingradle.properties: the newest release that shipsboss-ipc-1.0.0.jarplusboss-ui-sdk,plugin-api-coreandplugin-api-ipcat 1.0.0. It sits next toipc.version, with a note to bump the two together.downloadDepsdefaults to that tag instead oflatest.-Pupstream.sourcestill overrides it.FileNotFoundException.<jar>.partand moved into place only when complete. Before, a download cut off part-way left a truncated jar that thealready presentcheck accepted on every later run.release.ymlis unchanged in behaviour: with nobossconsole_release_tag, it now passes/releases/latest/downloadexplicitly, which is what it got before by default. A release run that overridesipc_versionto a version onlylatestships keeps working.Verification
From a clean
build/withCI=true:./gradlew downloadDepsfetches all four jars from v9.5.19../gradlew buildpasses: BUILD SUCCESSFUL, 256 tests, 0 failures.-Pupstream.release.tag=v9.5.22fails with the new message and leaves no partial file behind.Note for #21
#21 moves
ipc.versionto 1.1.0. With this change it also needsupstream.release.tag=v9.5.20, the release that shipsboss-ipc-1.1.0.jar. Without that, the new error names exactly what to change.