feat: expose bookmark library and shared opening contracts - #63
Draft
manishakuhar wants to merge 1 commit into
Draft
manishakuhar wants to merge 1 commit into
manishakuhar wants to merge 1 commit into
Conversation
manishakuhar
force-pushed
the
feat/bookmark-library-contracts
branch
from
September 17, 2026 05:38
0cc31da to
303f461
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The bookmark library currently needs a locally built host contract jar because the official SDK does not expose its library or shared-opening APIs. This adds the six matching contract types so consumers can use an official SDK release after this prerequisite is merged and released.
The contracts cover revision-checked mutations, independent favorite membership, explicit unfiled folder identity, mutation results, and window-scoped bookmark opening. Existing APIs and model constructors are unchanged; the API dump adds 112 lines and removes none. The six classes have identical public JVM descriptors to the host implementation in risa-labs-inc/BossConsole#759.
Validation:
./gradlew apiDumpfollowed separately by./gradlew buildpasses, includingapiCheckand all 121 tests. A new linkage regression checks the Compose$stablefields needed by consuming plugins. Public descriptors were compared with the built host bookmark-types jar usingjavap -public -s.This is a prerequisite for risa-labs-inc/boss-plugin-bookmarks#22. SDK types do not guarantee host behavior: that plugin now checks the registered
BookmarkOpeningProviderbefore initializing storage or migrating data. Once maintainers release this SDK change, the plugin can pin the actual released version and itsminApiVersion, remove the temporary source-contract build, and use the existing release workflow. No future SDK/BOSS version is guessed, no SDK release is created here, and no production plugin is published. Kept draft for coordinated maintainer review with the host/plugin changes.