Make Rust constants public#399
Open
Timmmm wants to merge 1 commit intoriscv:masterfrom
Open
Conversation
This is the more flexible option. It's easy to make them all private again by just not making the module itself public. But as it is making them all public requires hacky regex replacements in the file. Signed-off-by: Tim Hutt <tdhutt@gmail.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #399 +/- ##
==========================================
+ Coverage 96.53% 97.08% +0.55%
==========================================
Files 10 14 +4
Lines 750 926 +176
==========================================
+ Hits 724 899 +175
- Misses 26 27 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
aswaterman
approved these changes
Jan 7, 2026
Member
aswaterman
left a comment
aswaterman
left a comment
There was a problem hiding this comment.
Makes sense to me, but I'll let this marinate for a while so some of the Rust users can chime in. Ping me again in a few days if there's no opposition and I'll merge it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the more flexible option. It's easy to make them all private again by just not making the module itself public. But as it is making them all public requires hacky regex replacements in the file.