Skip to content

Feat: new product page - #255

Open
asaadam wants to merge 6 commits into
previewfrom
feat/newProductPage
Open

Feat: new product page#255
asaadam wants to merge 6 commits into
previewfrom
feat/newProductPage

Conversation

@asaadam

@asaadam asaadam commented Jul 13, 2022

Copy link
Copy Markdown
Contributor

https://www.loom.com/share/f7511fb979174f8f929b038e4ecd69b0

  • create new information token card component with compound component
  • provide dash component that can be inserted with text (currently only support left and right text)
  • create new backing information card with table
  • create new calculator component ( minus slider )
  • move my assets to below chart
  • add keyboard shortcut handler for swap ( shift + s )

@asaadam
asaadam requested review from math-marcellino and pyk July 13, 2022 07:40
@cloudflare-workers-and-pages

cloudflare-workers-and-pages Bot commented Jul 13, 2022

Copy link
Copy Markdown

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 2548ce8
Status: ✅  Deploy successful!
Preview URL: https://aea1cc7b.frontend-3mt.pages.dev
Branch Preview URL: https://feat-newproductpage.frontend-3mt.pages.dev

View logs

<p className="text-sm font-semibold leading-4 tracking-[-.02em] text-gray-light-12 dark:text-gray-dark-12">{metadata.debtSymbol}</p>
</td>
<td>
{uiData.status === "loading" && <p className="h-[16px] w-[100px] animate-pulse rounded-[8px] bg-gray-light-3 dark:bg-gray-dark-3"></p>}

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

h-[16px] h-4

rounded-[8px] to rounded-lg

Comment thread styles/globals.css
}
}

kbd {

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@asaadam what is it for?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

for this one ser

Comment thread uikit/card/InformationCard.tsx Outdated

const InformationCardExtra = ({ children, className }: { children: ReactNode; className?: string }) => {
return (
<div style={{ marginBottom: "-1rem !important" }} className={`-m-4 rounded-b-[16px] py-2 px-4 text-sm leading-6 text-white dark:text-gray-dark-10 ${className || ""}`}>

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rounded-b-[16px] to rounded-b-2xl

@pyk

pyk commented Jul 13, 2022

Copy link
Copy Markdown
Contributor

The navbar is show up when the swap/mint modal open

@math-marcellino

math-marcellino commented Jul 13, 2022

Copy link
Copy Markdown
Collaborator

The navbar is show up when the swap/mint modal open

Ahh yess sorry I think it's my fault. It's because we change the navbar to be sticky. I'll fix it in the next PR sir... @pyk

@asaadam

asaadam commented Jul 13, 2022

Copy link
Copy Markdown
Contributor Author

@pyk updated ser

@asaadam
asaadam requested a review from pyk July 13, 2022 09:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants