Skip to content

Spelling rework - #393

Open
comradekingu wants to merge 3 commits into
riseuplabs:masterfrom
comradekingu:patch-1
Open

Spelling rework#393
comradekingu wants to merge 3 commits into
riseuplabs:masterfrom
comradekingu:patch-1

Conversation

@comradekingu

Copy link
Copy Markdown

Markup, escaping and capitalization might be a bit off

@azul

azul commented Feb 9, 2018

Copy link
Copy Markdown
Contributor

Hi @comradekingu ,

Thanks a lot for your fixes. Very helpful.
I spotted one formatting issue. Will comment in line.

Comment thread config/en.yml Outdated
cookie_disabled_warning: You have cookies disabled. You will not be able to login
until you enable cookies.
email_verification_body: |-
congratulations_you_have_signed_up: "Congratulations! You have signed up for %{site_title}.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The quotation marks " include the following line in this translation. But the cookie_disabled_warning is a separate string all together.

Comment thread config/en.yml
congratulations_you_have_signed_up: "Congratulations! You have signed up for %{site_title}.
cookie_disabled_warning: You have cookies disabled. You will not be able to log in
until you enable cookies."
email_verification_body: "|-

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think you need quotes here. The |- already is yaml syntax for a multi line value.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants