Update Navbar.jsx - #22
Open
Amansingh0807 wants to merge 1 commit into
Open
Amansingh0807 wants to merge 1 commit into
Amansingh0807 wants to merge 1 commit into
Conversation
Created a reusable NavLink component for mobile menu items to reduce redundancy. Removed unnecessary md:border class in the mobile menu. Simplified the logic for toggling the mobile menu, reducing repetitive code. I did all the changes that were mentioned in the issue number rishyym0927#21. Have a look at the changes if anything is require to be changed, please let me know for the same.
|
@Amansingh0807 is attempting to deploy a commit to the Rishiraj Mukherjee's projects Team on Vercel. A member of the Team first needs to authorize it. |
✅ Deploy Preview for precious-raindrop-7918a1 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Owner
|
@Amansingh0807 write proper commit message in the PR and add relevant screenshots and video recordings. Add detailed comment in your code too !! |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Created a reusable NavLink component for mobile menu items to reduce redundancy. Removed unnecessary md:border class in the mobile menu. Simplified the logic for toggling the mobile menu, reducing repetitive code. I did all the changes that were mentioned in the issue number #21. Have a look at the changes if anything is require to be changed, please let me know for the same.