feat(storage): restart and finish part 1, 2 #16
Merged
Conversation
Signed-off-by: Alex Chi <iskyzh@gmail.com>
Signed-off-by: Alex Chi <iskyzh@gmail.com>
Signed-off-by: Alex Chi <iskyzh@gmail.com>
b84824e to
8b66679
Compare
wangrunji0408
approved these changes
Feb 25, 2022
Member
wangrunji0408
left a comment
There was a problem hiding this comment.
LSTM!
For 03-01, now only the last inserted data could be read. Is it a bug or by design?
Click to see the outputs
cargo run -p risinglight-03-01
> create table t(a int);
+---+
| 1 |
+---+
> insert into t values (1), (2);
+---+
| 2 |
+---+
> insert into t values (3), (4);
+---+
| 2 |
+---+
> select * from t;
+---+
| 3 |
| 4 |
+---+
For the test, can we add some features to sqllogictest for testing durability?
Member
Author
Yes, it's by design. We only support multi-insert after introducing the concept of RowSet.
I don't think there's need to do this. Firstly, we don't have manifest. Even if all data are on disk, we won't know there are after restart. Secondly, we don't have mem table, so there's no possibility that data are read from memory. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The diff history can be found at #15, and the
update-storage-tutorialscript will copy code from each commit of thestoragebranch to the main repo.