Skip to content

test: organize Bitwarden account mapping cases - #1586

Open
risu729 wants to merge 1 commit into
mainfrom
refactor/bitwarden-account-tests-20261112
Open

risu729 wants to merge 1 commit into
mainfrom
refactor/bitwarden-account-tests-20261112

Conversation

@risu729

@risu729 risu729 commented Nov 12, 2026 •

Copy link
Copy Markdown
Owner

The account test entry exceeded the 1,000-line limit and mixed native-crypto integration with admission, modern-account validation, item mapping and URI context. Keep its original imports, fixtures, session cleanup, native-crypto group and five describe scopes in the entry. Four passive registrars own the unchanged remaining groups, using erased inferred context types and the same references. The entry is 659 lines; modules are 181, 133, 304 and 144 lines. Remove only its max-lines exemption and document the arrangement.

Independent source review of the final head found no issues: complete expanded AST/raw token stream, comments, import owners/order, binding identities and initialization points match. The 73 declarations yield 155 cases with 143 expect source sites. URI local helpers retain their original lifetime, and root cleanup is unchanged. All five TypeScript files are byte-identical across the equal-range-diff rebase.

Separate runtime verification used current-base dependencies and injected original Git source at the identical module path: baseline 155/155 passed (3.65s), and the existing full Bitwarden task with coverage passed 1,538/1,538 across 17 files (24.81s). All case IDs, full titles, order, results, suite IDs and explicit parents match. Discovery remains 17 entries; coverage contains 22 production files and excludes helpers/test entries. Typecheck, scoped static checks and documentation validation pass.

Final CI passed Verify, Orders and components, all six browser shards and CI Check; CodeQL passed both analyses. The actual tested merge tree equals the final head with the expected base. Every task count matches that base's CI: Verify 9,186 tests/274 files plus 73 tool tests, and components 1,814 tests/108 files. Timings are mixed: Verify 266→262s, runtime 200.57→200.01s, Bitwarden 64.94→63.30s and affected entry 20.719→18.199s; components were slower at 136→223s, with all four component tasks higher. These single-run observations do not establish causal performance changes or zero regression.

Part of the approved refactor scope. No production behavior, assertions, timeout, discovery or coverage changes. No merge or auto-merge requested.

@risu729 risu729 left a comment

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Independent source review of the final head: no actionable findings.

Complete reconstructed program AST and raw token stream match the baseline, including comments, strings, regular expressions, assertions, tables, hooks, helpers and statement order. Preserved 73 declarations, 155 expanded cases and 143 expect source sites: native 34, admission 41, modern 23, item mapping 42, URI context 15.

Four registrars remain synchronous and passive on import. References retain identity and URI-local initializers retain their registration point. No this/arguments/eval, temporal-dead-zone, snapshot or lifetime hazards. Fixture/import ownership and root cleanup are preserved, and erased type back-references introduce no runtime cycle. Discovery, coverage and task configuration are unchanged. File sizes, target exemption removal and docs are accurate. All five TypeScript files are byte-identical across rebase; range-diff is equal and the worktree/whitespace checks are clean. Source review only; runtime and CI are separate.

@risu729
risu729 marked this pull request as ready for review November 12, 2026 13:56

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant