Skip to content

refactor(contracts): separate vault policy save cases - #1591

Draft
risu729 wants to merge 1 commit into
mainfrom
refactor/contract-vault-policy-tests-20261112
Draft

risu729 wants to merge 1 commit into
mainfrom
refactor/contract-vault-policy-tests-20261112

Conversation

@risu729

@risu729 risu729 commented Nov 12, 2026 •

Copy link
Copy Markdown
Owner

Vault policy settings-save reconciliation cases now live in a passive registrar, reducing the discovered entry from 1,095 to 902 lines. The 245-line helper preserves all ten scopes, shared fixtures, the late save initializer and synchronous local initialization. Only this entry's line-limit exception is removed; development documentation describes the ownership.

The previous source review, original/current runtime comparison (62 target cases; full contracts 1,055 cases/28 ordinary files plus separate CI orders 16/10), CI, and CodeQL passed at previous head.

Concurrent main integrations then produced a documentation conflict. Current head preserves the upstream API-owner/local-crypto sections and appends this scope's section. The entire contracts package is byte-identical to the verified head, and the original target baseline is unchanged. The range comparison changes only lint/documentation context. Documentation checks pass (137 files, 2,331 links). Runtime evidence is retained with this explicit attribution; final review of the rebase and new full CI/CodeQL are pending, so the PR is draft again. No merge or auto-merge.

@risu729 risu729 left a comment

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Independent source review: CLEAR at final HEAD.

Independently expanded the final entry and verified exact equality with original source bytes, AST, tokens, raw literals, assertions, comments and order. All ten suites remain; 45 registration sites expand to 62 cases. The moved final scope retains nine registrations / ten cases. All 13 forwarded bindings match, reverse imports are type-only, and the registrar remains passive and synchronous. Root fixtures, storage helper, late save initializer and scope-local helper lifetimes remain unchanged. Both TypeScript files are byte-identical to the author revision after rebasing. Discovery, coverage, tasks and production code are unchanged; documentation accurately describes ownership. No actionable findings.

Source review only. Separate runtime comparison and full CI are tracked independently.

@risu729
risu729 marked this pull request as ready for review November 12, 2026 14:14
@risu729
risu729 force-pushed the refactor/contract-vault-policy-tests-20261112 branch from faad823 to 5d9aaf1 Compare November 12, 2026 14:16
@risu729
risu729 marked this pull request as draft November 12, 2026 14:16

@risu729 risu729 left a comment

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Independent final rebase review: CLEAR at new HEAD.

The entire contracts directory matches the previously reviewed revision. The original target base blob, relevant production dependencies, lockfile and test configuration are unchanged. Documentation preserves upstream API-owner and local-crypto sections verbatim and adds only the accurate vault-policy section. Configuration removes only the target exception. Worktree is clean and whitespace validation passes. Previous complete source review remains applicable; retained local runtime evidence is explicitly attributed to the byte-identical prior source. No additional runtime tests or remote changes were performed by this reviewer.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant