Repository navigation
test: organize local crypto cases without changing discovery - #1593
Merged
Merged
Conversation
Import the TOTP secret directly like the other fixtures, share the module contexts through context.ts, and drop the misplaced docs section ahead of its rewrite. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_011PUTx3w1HVYZp73fQasU3g
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_011PUTx3w1HVYZp73fQasU3g
# Conflicts: # docs/development.md
This was referenced Nov 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces #1584 and keeps its commit, plus review fixes.
Summary
packages/bitwarden/src/local-crypto.test.tskeeps the synthetic account and SDK helpers, the sharedsessionsarray, the rootafterEachand the three describe scopes. Synchronous registrar modules inpackages/bitwarden/test/local-crypto/hold the account initialization, cipher isolation and item repair cases.local-crypto.test.tsmax-lines exemption is removed from.oxlintrc.json(the largest file is 704 lines).Review fixes on top of #1584
cipher-isolation.tsimportsbitwardenTotpSecretfrom__fixtures__/totpdirectly, like its other fixtures, instead of receiving it through the context. The entry drops that import and field.test/local-crypto/context.tswithAccountInitializationContext,CipherIsolationContextandItemRepairContext, replacing the hand-writtenPicklists in each module.LocalCryptoTestFixturesandcontext.ts, says the modules are not discovered as test files, and drops the dependency-order rationale, since__fixtures__/totponly exports constants.Verification
src/local-crypto.test.ts: 126, identical to main and all passing.oxfmt --check,oxlint packages/bitwarden,rumdl check docs/development.md,mise run //packages/bitwarden:typecheckpass.Generated by Claude Code