fix(tests): resolve duplicate_service vectorized test suite mismatch and test pollution#792
Conversation
…nc and add ErrorBoundary
…er assertion errors
…istence-error-boundaries
…syntax/ESLint errors
…ency in incident service
…and test pollution
|
@harshitanagpal05 is attempting to deploy a commit to the ritesh Team on Vercel. A member of the Team first needs to authorize it. |
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Superb implementation, @harshitanagpal05! I've successfully resolved all conflicts in your PR and queued it for merging into
Keep up the outstanding work! Let's build together! 🔥 |
Summary
We have successfully resolved the test suite collection and runtime failures in the duplicate checking service tests.
Proposed Changes
backend.services.duplicate_servicestub injected byconftest.pyfromsys.modulesat test startup.torchlibrary to allow tests to calltorch.stack()andtorch.max()without failing on dummyMagicMockembeddings.teardown_methodinsideTestCheckDuplicateto automatically reset the shared_mock_st.util.cos_simmock side-effects and return values between test executions.test_picks_best_match_among_multiple_ticketsto model a single vectorized comparison call instead of looping individual comparisons.closes bug(tests): duplicate_service unit tests fail with TypeErrors & IndexErrors when running against actual vectorized service #790
Verification Results
All 24 unit tests now compile and pass cleanly in 14.48s: