Potential fix for code scanning alert no. 3: Workflow does not contain permissions#77
Merged
Conversation
…n permissions Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds GitHub Actions workflow permissions configuration to restrict the default token permissions for security hardening. The change sets contents: read as an explicit permission, following the principle of least privilege.
Key Changes
- Added explicit
permissionsblock to limit workflow token access to read-only content access
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Potential fix for https://github.com/riverlane/QStone/security/code-scanning/3
To fix the issue, we will add a
permissionsblock at the root level of the workflow to define default permissions for all jobs. This ensures that thebuildjob, which currently lacks explicit permissions, will inherit these minimal permissions. Thepublishjob already has its ownpermissionsblock, so it will not be affected by the root-level permissions.The minimal permissions required for the
buildjob arecontents: read, as it only needs to read the repository contents to build the distribution. We will add this to the root of the workflow.Suggested fixes powered by Copilot Autofix. Review carefully before merging.