Merged
Conversation
Member
|
i don't remember writing the plugin using cpp20, but sure. |
wargio
approved these changes
Feb 17, 2026
Member
Author
|
it's not because of you ... somehow the Windows version of the plugin pulls in stuff like https://github.com/rizinorg/rizin/blob/693dff153b70dfc0745136d78e633b857dcccc22/subprojects/rzheap/rz_glibc/glibc_versions.h#L83-L100 (i've not been able to get g++ to complain; also, making that C++17-compliant is a pita) and according to MSVC (and cppreference.com), that kind of initialization requires C++20 |
This was referenced Feb 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pr uses C++20 for the jsdec Cutter plugin since apparently that is what is needed by MSVC nowadays:
(https://github.com/rizinorg/cutter/actions/runs/22019977842/job/63627441483#step:9:11698)