Ryan.coulter/scatest#1
Open
rjcoulter22 wants to merge 3 commits into
Open
Conversation
Trying to test opening a PR with bad code that should be caught by static analysis
Trying to test opening a PR with bad code that should be caught by static analysis
Testing, should hopefully flag with python rule
![datadog-ryan-gitbhub[bot]](https://avatars.githubusercontent.com/u/184255232?s=60&v=4){kind=small}
| ''' | ||
| def __bytes__(self): | ||
| pass | ||
| return "123" |
There was a problem hiding this comment.
⚪ Code Quality Violation
Suggested change
| return "123" | |
| return b"123" |
should return bytes, prefix with b (...read more)
The __bytes__ method should not return a string and instead, ensure to return bytes.
| import re | ||
| import sys | ||
|
|
||
| class CodeViolation: |
There was a problem hiding this comment.
⚪ Code Quality Violation
Class CodeViolation should have an init method (...read more)
Ensure that a class has an __init__ method. This check is bypassed when the class is a data class (annotated with @DataClass).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Create Test PR